React-swipeable-viewsからSwiperへのリプレイス #128
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- npm run lint : eslintの警告を表示 - npm run fix : 自動で色々直してくれる
|
Visit the preview URL for this PR (updated for commit 8e2c5e3): https://mobile-order-4d383--pr128-replace-swiper-j6jkwt9v.web.app (expires Tue, 07 Mar 2023 07:37:06 GMT) 🔥 via Firebase Hosting GitHub Action 🌎 Sign: d05948d1c21d3195428590dd6f13a9369eb73441 |
Nikudanngo
commented
Feb 28, 2023
Nikudanngo
added a commit
that referenced
this pull request
Mar 2, 2023
* delete react-swipeable-views * いくつかの依存関係のバージョンアップ * prettier-plugin-tailwindcssの追加 * npm i eslint-plugin-tailwindcss * tailwindフォーマットプラグイン導入 * npm コマンド追加 - npm run lint : eslintの警告を表示 - npm run fix : 自動で色々直してくれる * prettierによる自動整形とtailwindのwarning解消 * デグレ修正 * npm i swiper * react-swipeable-viewsからSwiperへのリプレイス - 処理のメモ化 * git hub actionsの-fオプション外した * Menuにmax-wを追加 * delete comment * FoodCartを左寄せ * FoodCardのSOLD OUTのカラー修正
Nikudanngo
added a commit
that referenced
this pull request
Mar 2, 2023
* delete react-swipeable-views * いくつかの依存関係のバージョンアップ * prettier-plugin-tailwindcssの追加 * npm i eslint-plugin-tailwindcss * tailwindフォーマットプラグイン導入 * npm コマンド追加 - npm run lint : eslintの警告を表示 - npm run fix : 自動で色々直してくれる * prettierによる自動整形とtailwindのwarning解消 * デグレ修正 * npm i swiper * react-swipeable-viewsからSwiperへのリプレイス - 処理のメモ化 * git hub actionsの-fオプション外した * Menuにmax-wを追加 * delete comment * FoodCartを左寄せ * FoodCardのSOLD OUTのカラー修正
Nikudanngo
added a commit
that referenced
this pull request
Mar 2, 2023
* delete react-swipeable-views * いくつかの依存関係のバージョンアップ * prettier-plugin-tailwindcssの追加 * npm i eslint-plugin-tailwindcss * tailwindフォーマットプラグイン導入 * npm コマンド追加 - npm run lint : eslintの警告を表示 - npm run fix : 自動で色々直してくれる * prettierによる自動整形とtailwindのwarning解消 * デグレ修正 * npm i swiper * react-swipeable-viewsからSwiperへのリプレイス - 処理のメモ化 * git hub actionsの-fオプション外した * Menuにmax-wを追加 * delete comment * FoodCartを左寄せ * FoodCardのSOLD OUTのカラー修正
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
背景
react-swipeable-viewsがReact18で非推奨になっており、
npm iのたびに-fオプションをつけないとまともに動かない状況だった。そのため、代わりにSwiperに乗り換えて、ついでにreact-swipeable-viewsをnpmから削除してその他の依存関係をアップデートしたい
変更
npm run lint,npm run fixコマンドを追加 : 警告と修正するコマンド