Fix auth checking helpers #707
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The `withAuth` option belongs to the DrupalClient.fetch() method but was mistakenly being passed to the init param of the global fetch and custom fetcher functions.
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎ 1 Ignored Deployment
|
robdecker
approved these changes
Feb 26, 2024
1 task
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request is for:
packages/next-drupalGitHub Issue: #667
Describe your changes
The
isBasicAuth,isAccessTokenAuth, andisClientIdSecretAuthare all mis-implemented. This PR fixes the implementations and uses of those helper functions.The PR also abstracts the creation of the
Authorizationheader with a newgetAuthorizationHeadermethod and removes theTODO: Abstract this to a re-usablethat Shad had added. Before this method was added theBuffer.from(`${username}:${password}`).toString("base64")code pattern was in DrupalClient 3 different times.Lastly, I noticed that the
withAuthoption toDrupalClient.fetch()was being passed down to theinitparam of the globalfetch()when it is not one of the allowed init properties. So I've updated the code to consume thewithAuthoption inDrupalClient.fetch()and prevent it from being passed down to the underlying fetcher.