Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add tooling to test code coverage #610

Merged
merged 1 commit into from
Dec 6, 2023
Merged

Conversation

JohnAlbin
Copy link
Contributor

This pull request is for:

  • packages/next-drupal

GitHub Issue: #609

Describe your changes

Add code coverage tests and adds minimum thresholds for code coverage.

Copy link

vercel bot commented Nov 22, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

1 Ignored Deployment
Name Status Preview Comments Updated (UTC)
next-drupal ⬜️ Ignored (Inspect) Visit Preview Dec 3, 2023 5:28am

@JohnAlbin JohnAlbin force-pushed the 609-test-code-coverage branch 2 times, most recently from 399a64a to 6c4f6df Compare November 22, 2023 15:17
@JohnAlbin
Copy link
Contributor Author

GitHub Actions run each Jest suite per packages/* entry. So I had to move the jest config into each package to get code coverage enabled. Otherwise, each packages/* test suite would try to report the coverage percentages of the whole monorepo.

@JohnAlbin JohnAlbin requested a review from robdecker November 22, 2023 15:25
@JohnAlbin JohnAlbin force-pushed the 609-test-code-coverage branch 3 times, most recently from fd5ce9f to e95f3e1 Compare November 28, 2023 13:15
@JohnAlbin JohnAlbin force-pushed the 609-test-code-coverage branch from e95f3e1 to 0b67240 Compare December 3, 2023 05:28
Copy link
Member

@robdecker robdecker left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

@JohnAlbin JohnAlbin merged commit 278bd1e into main Dec 6, 2023
8 checks passed
@JohnAlbin JohnAlbin deleted the 609-test-code-coverage branch December 6, 2023 10:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants