-
Notifications
You must be signed in to change notification settings - Fork 424
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
add split-init error when uninitialized var used as actual #26497
Draft
arezaii
wants to merge
10
commits into
chapel-lang:main
Choose a base branch
from
arezaii:split-init-error
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
+179
−21
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Ahmad Rezaii <[email protected]>
Signed-off-by: Ahmad Rezaii <[email protected]>
Signed-off-by: Ahmad Rezaii <[email protected]>
Signed-off-by: Ahmad Rezaii <[email protected]>
DanilaFe
reviewed
Jan 9, 2025
Signed-off-by: Ahmad Rezaii <[email protected]>
Signed-off-by: Ahmad Rezaii <[email protected]>
arezaii
force-pushed
the
split-init-error
branch
from
January 9, 2025 02:49
e088043
to
7ab602b
Compare
Signed-off-by: Ahmad Rezaii <[email protected]>
arezaii
force-pushed
the
split-init-error
branch
from
January 9, 2025 02:57
940bba9
to
7cd3868
Compare
DanilaFe
reviewed
Jan 13, 2025
Signed-off-by: Ahmad Rezaii <[email protected]>
Signed-off-by: Ahmad Rezaii <[email protected]>
Signed-off-by: Ahmad Rezaii <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds detection of an uninitialized variable used as an actual to a non-out formal. The previous error was a generic failure to resolve function [NoMatchingCandidates] and this improves the message by indicating that the candidate did not match because of the uninitialized actual passed to a non-out formal.
resolves https://github.com/Cray/chapel-private/issues/6624
Example program:
in production this produces the following error message:
previous error message compiling with
chpl MyTestModule.chpl --dyno --detailed-errors
:Updated error message with
-dyno --detailed-errors
:updated error message with
--dyno --no-detailed-errors
TESTING:
[Summary: #Successes = 17676 | #Failures = 0 | #Futures = 891]
[Summary: #Successes = 17857 | #Failures = 0 | #Futures = 900]