Restore the ability to use reals for timeout in the Socket module #26486
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It looks like the Socket module (or something else) had the capability to cast a
real
into astruct timeval
at some point. Then that got removed. I haven't followed the breadcrumbs to learn the full story. However, the Socket module had some interface wherereal
is accepted for a timeout, which then casted tostruct timeval
using that now-nonexistent cast.The current behavior on main is that the interfaces that accepts reals for timeouts simply don't resolve and they are untested. This PR adds the capability back via a private helper instead of a cast, and expands some of the timeout testing.
Test:
test/library/package/Socket