Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Restore the ability to use reals for timeout in the Socket module #26486

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

e-kayrakli
Copy link
Contributor

It looks like the Socket module (or something else) had the capability to cast a real into a struct timeval at some point. Then that got removed. I haven't followed the breadcrumbs to learn the full story. However, the Socket module had some interface where real is accepted for a timeout, which then casted to struct timeval using that now-nonexistent cast.

The current behavior on main is that the interfaces that accepts reals for timeouts simply don't resolve and they are untested. This PR adds the capability back via a private helper instead of a cast, and expands some of the timeout testing.

Test:

  • local test/library/package/Socket

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant