differentiation in single and double quotes #23
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@lydia-duncan Is there a way to verify the solution , so that this can be merged ? |
|
Can you change your VS-code to reference your chapel-tmbundle instead of the default one? |
rapiz1
reviewed
Mar 25, 2020
parthsarthiprasad
force-pushed
the
tmbundlequotes
branch
from
d51a242 to
5b41c05
Compare
|
yep @lydia-duncan This change fixes , this , correcting and reabasing all the commits into one now, created a new package to cross verify , this also corrects , @rapiz1 issue. new |
parthsarthiprasad
force-pushed
the
tmbundlequotes
branch
from
5b41c05 to
9e09f13
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
related to issue #21 ,
I've tried to correct the chapel-tmbundle issue and hope that this will work , but right now I am unable to test the solution , since lightshow doesn't clearly show differences in single and double quotes, rest , this won't break the code I hope , Made a different branch till there's a way to verify the solution(which I feel will work though).