Merge pull request #2818 from chaoss/xdev

Xdev: Final Patches for Release

augur/tasks/git/dependency_libyear_tasks/libyear_util/npm_libyear_utils.py

@@ -1,5 +1,6 @@
 import requests
 import logging 
+import traceback 
 
 logger = logging.getLogger(__name__)
 
@@ -48,8 +49,9 @@ def get_lastest_minor(version, data):
     try: 
         versions = data['versions']
     except Exception as e: 
-        logger.info(f'error is {e} on the NPM. Hey, its NODEJS, of course it does not work :D ')
-        raise e 
+        logger.info(
+                    ''.join(traceback.format_exception(None, e, e.__traceback__)))
+      #  raise e 
 
     try:
         index = list(versions.keys()).index(version)

augur/tasks/github/pull_requests/tasks.py

@@ -14,6 +14,8 @@
 from ..messages.tasks import process_github_comment_contributors
 from augur.tasks.github.util.github_random_key_auth import GithubRandomKeyAuth
 
+import httpx
+
 from typing import Generator, List, Dict
 
 
@@ -212,7 +214,6 @@ def process_pull_request_review_contributor(pr_review: dict, tool_source: str, t
 
     return pr_review_cntrb
 
-
 @celery.task(base=AugurSecondaryRepoCollectionTask)
 def collect_pull_request_review_comments(repo_git: str) -> None:
 
@@ -368,6 +369,17 @@ def collect_pull_request_reviews(repo_git: str) -> None:
             if len(page_data) == 0:
                 break
 
+            if isinstance(page_data, list):
+                page_data = [
+                    element.decode('utf-8').replace('\x00', ' ') if isinstance(element, bytes) else element
+                    for element in page_data
+                ]
+                logger.info(f"NUL characters were found in PR Reviews and replaced with spaces.") 
+            elif isinstance(page_data, bytes):
+                page_data = page_data.decode('utf-8').replace('\x00', ' ')
+                logger.info(f"NUL characters were found in PR Reviews and replaced with spaces.") 
+
+
             pr_reviews.extend(page_data)
 
         if pr_reviews: