-
Notifications
You must be signed in to change notification settings - Fork 488
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Internal: Fix HTML resource links for migrated OFAJ portal" - refs BT#22199 #6017
base: master
Are you sure you want to change the base?
Conversation
@@ -0,0 +1,157 @@ | |||
<?php | |||
|
|||
declare(strict_types=1); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Add a single space around assignment operators
use Doctrine\DBAL\Schema\Schema; | ||
use Exception; | ||
|
||
final class Version20250106151300 extends AbstractMigrationChamilo |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Missing class doc comment
|
||
final class Version20250106151300 extends AbstractMigrationChamilo | ||
{ | ||
public function getDescription(): string |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Missing function doc comment
return 'Fix incorrect resource links in HTML files already migrated.'; | ||
} | ||
|
||
public function up(Schema $schema): void |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Missing function doc comment
$course = $courseRepo->find($currentCourseId); | ||
if (!$course) { | ||
error_log("Document ID $documentId, Resource Node $resourceNodeId: Course with ID $currentCourseId not found."); | ||
return $matches[0]; // Return original link if course not found |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Missing blank line before return statement
Code Climate has analyzed commit 1994828 and detected 13 issues on this pull request. Here's the issue category breakdown:
View more on Code Climate. |
No description provided.