Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Internal: Fix HTML resource links for migrated OFAJ portal" - refs BT#22199 #6017

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

christianbeeznest
Copy link
Contributor

No description provided.

@@ -0,0 +1,157 @@
<?php

declare(strict_types=1);
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Add a single space around assignment operators

use Doctrine\DBAL\Schema\Schema;
use Exception;

final class Version20250106151300 extends AbstractMigrationChamilo
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Missing class doc comment


final class Version20250106151300 extends AbstractMigrationChamilo
{
public function getDescription(): string
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Missing function doc comment

return 'Fix incorrect resource links in HTML files already migrated.';
}

public function up(Schema $schema): void
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Missing function doc comment

$course = $courseRepo->find($currentCourseId);
if (!$course) {
error_log("Document ID $documentId, Resource Node $resourceNodeId: Course with ID $currentCourseId not found.");
return $matches[0]; // Return original link if course not found
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Missing blank line before return statement

Copy link

codeclimate bot commented Jan 7, 2025

Code Climate has analyzed commit 1994828 and detected 13 issues on this pull request.

Here's the issue category breakdown:

Category Count
Style 8
Bug Risk 3
Clarity 2

View more on Code Climate.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant