chore: update scripts to initialize with project_name #34
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Miguel Martinez <[email protected]>
migmartri
commented
Oct 9, 2024
migmartri
commented
Oct 9, 2024
| if: github.event_name == 'release' && github.event.action == 'published' | ||
| with: | ||
| project: ${{ inputs.workflow_project }} |
There was a problem hiding this comment.
I am not sure how this ever worked. Did I miss anything cc/ @javirln
migmartri
commented
Oct 9, 2024
| @@ -676,7 +676,11 @@ chainloop_attestation_init() { | |||
| if [ -n "${CHAINLOOP_WORKFLOW_NAME}" ]; then | |||
| WF_NAME_VALUE="--workflow-name ${CHAINLOOP_WORKFLOW_NAME}" | |||
| fi | |||
| r=$(chainloop attestation init -f --remote-state --output json $CR_VALUE $WF_NAME_VALUE) | |||
| PROJECT_NAME_VALUE="" | |||
There was a problem hiding this comment.
@danlishka I might need your help here. I am trying to figure out how the push works.
I think it uses some kind of cache, but I guess that now we will need to update the cache to also take into account the project name, but I am struggling to find that. No rush
There was a problem hiding this comment.
ahh no, the cache is unique within the run, ok.
I am wondering then why we are passing the workflow name here
|
Coverted to draft until I figure out how to make the |
jiparis
approved these changes
Oct 10, 2024
Signed-off-by: Miguel Martinez <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Update labs code to get ready for this change chainloop-dev/chainloop#1375
It adds the requirement of doing
att initindicating the project name.Note that I also updated the onboarding project to return the project name too.