Diff api: Include scanner metadata in Diff API response #103
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We want to return the scanner type and version in the response. Signed-off-by: Priya Wadhwa <[email protected]>
priyawadhwa
force-pushed
the
grype-version
branch
from
6fbe141 to
a8c5939
Compare
cmdpdx
approved these changes
Jan 31, 2024
hectorj2f
reviewed
Feb 1, 2024
| @@ -404,6 +404,9 @@ message PackageReference { | |||
| message VulnerabilitiesDiff { | |||
| repeated VulnerabilityReference added = 1; | |||
| repeated VulnerabilityReference removed = 2; | |||
| chainguard.platform.tenant.Scanner scanner = 3; | |||
| // vulnerability_db_last_build_time holds the time when the vulnerability database was built last time. | |||
| google.protobuf.Timestamp vulnerability_db_last_build_time = 4; | |||
There was a problem hiding this comment.
I was thinking more of having:
message VulnScannerDiff {
ChangedVulnScanner changed = 1;
}
message ChangedVulnScanner {
message ChangedVulnScannerName {
string current = 1;
string previous = 2;
}
ChangedVulnScannerName changedName = 1;
message ChangedVulnScannerVersion {
string current = 1;
string previous = 2;
}
ChangedVulnScannerVersion changedVersion = 2;
message ChangedVulnScannerVulnerabilityDbLastBuildTime {
google.protobuf.Timestamp current = 1;
google.protobuf.Timestamp previous = 2;
}
ChangedVulnScannerVulnerabilityDbLastBuildTime changedVulnerabilityDbLastBuildTime = 2;
}
where VulnScannerDiff is in VulnerabilitiesDiff .
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We want to return the scanner type and version in the response.