Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixes #17 #21

Closed
wants to merge 4 commits into from
Closed

Fixes #17 #21

wants to merge 4 commits into from

Conversation

amosonn
Copy link

@amosonn amosonn commented Feb 7, 2017

Fixes #17: Still scatters thumbnails, but other than that it works.

@cgsecurity
Copy link
Owner

In file_finish_aux(), it will be best to avoid calling set_date(), file_rename() and creating directories for files that are deleted.
In jpg_check_structure() from src/file_jpg.c, avoid to create a jpg thumb file.

@amosonn
Copy link
Author

amosonn commented Jan 29, 2018

I haven't had much time to look at it, will try this week.

The first few seem possible. The reason I didn't implement the latter, is that the settings struct is not passed to that context, which makes it hard to determine whether a thumb needs or does not need to be created. I thought about adding it as a field to another struct passed there, but it seemed too ugly to me. If you say that's fine, I can go ahead and do it; otherwise, this requires some more refactoring (passing the settings struct to all file formats, which is some).

@amosonn amosonn closed this Jun 28, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[photorec] Feature: Only create report.xml
2 participants