feat: Add initial support to System Library #1428
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
0xLucasMarcal
changed the title
0xLucasMarcal
commented
Jan 4, 2025
| for bs in target.linker_settings.linked_libraries | ||
| ])) | ||
| if linkopts: | ||
| attrs["linkopts"] = _starlarkify_clang_attrs(repository_ctx, {"linkopts": linkopts})["linkopts"] |
There was a problem hiding this comment.
Fix: Add linked libraries to linkopts
The current implementation wasn't properly adding libraries to the linker options (linkopts), which caused linking failures for certain system dependencies. For example, targets that import sqlite3 were failing to build because the -lsqlite3 flag wasn't being passed to the linker.
|
@lucasmarcal-faire I converted this to a draft. Let us know when the PR is ready for review. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Initial Support for System Libraries
This PR adds initial support for system libraries in the build system. This implementation focuses on basic system library integration without external package manager support (e.g., Homebrew).
Changes
Limitations
Future Work
Testing