feat: Use GRPC from swift package manager #1418
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@cgrindel I think this is ready to go, and the Stripe test failure is unrelated to this PR. |
|
I already moved these examples to swift_gazelle_plugin. Can we apply this PR over there? |
|
Oh ok — I wasn’t sure if it was ready to use. When will it be published on the Bazel registry? |
|
I am working on it, right now. 🙂 |
|
@cgrindel Ok I ported the PR over to the new repo here: cgrindel/swift_gazelle_plugin#7 |
cgrindel
pushed a commit
to cgrindel/swift_gazelle_plugin
that referenced
this pull request
Dec 27, 2024
This PR is a port of this PR into RSPM: cgrindel/rules_swift_package_manager#1418 Last year I added support for generating swift_proto_library targets to the Gazelle plugin. I added these examples demonstrating the Gazelle plugin in action, but they were limited to the GRPC and SwiftProtobuf versions supplied by rules_swift. At the time, RSPM was not setting alwayslink = True on the generated swift_library targets which caused the tests to fail on Ubuntu. Since then, this issue has been resolved and the Gazelle plugin has been extracted to this separate repository. I have ported over my changes to use GRPC and its dependencies from Swift Package Manager. This enables consumers to independently upgrade these dependencies and avoid duplicate symbols with other libraries that also depend on these packages.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR updates the GRPC examples to use the GRPC obtained through RSPM instead of the one in rules_swift.
I was unable to land this previously because tests were failing on ubuntu without the alwayslink = True flag.
RSPM now sets this flag so it should work as expected.