Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

cemerick proposal + readme #130

Open
wants to merge 8 commits into
base: master
Choose a base branch
from
Open

cemerick proposal + readme #130

wants to merge 8 commits into from

Conversation

fdserr
Copy link
Collaborator

@fdserr fdserr commented Jul 10, 2015

No description provided.

@@ -992,7 +992,7 @@
(defn- nodify [node-spec]
(cond
(string? node-spec) node-spec
(vector? node-spec)
(and (vector? node-spec) (not (map? (first node-spec))))
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Rather than (not (map? (first node-spec))), (keyword? (first node-spec)) seems to better handle cases such as ["abc" {:tag :b :content ["def"]} "ghi"]. Doesn't it?

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Been thinking and trying, but I can't figure out what you mean 8-°
That would give us:

(html (at (html [:a])
             [:a] (content "foo")))
=> ({:tag ::a, :attrs {}, :content ()})

which can't be what you want?

Plus:
Ran 30 tests containing 104 assertions. 6 failures, 0 errors. {:test 30, :pass 98, :fail 6, :error 0, :type :summary}

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants