Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Dockerhub push gh actions #4877

Merged
merged 11 commits into from
Oct 15, 2024
Merged

Conversation

jaredb96
Copy link
Contributor

No description provided.

@jaredb96 jaredb96 self-assigned this Sep 5, 2024
@jaredb96 jaredb96 linked an issue Sep 5, 2024 that may be closed by this pull request
@@ -0,0 +1,38 @@
name: HMDA Docker Hub Image Push
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

General question: what fills in all the template values?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you clarify this question

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Where do all the values in curly brackets come from?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Those values have been configured on our public github repo

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you provide a link? I believe they're there, but it's not obvious to me where. They don't show up in my searches...

Copy link
Contributor

@tptignor tptignor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@jaredb96 jaredb96 merged commit 70f7b05 into cfpb:master Oct 15, 2024
13 of 15 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Push images to Dockerhub using Github Actions on PR Merge
2 participants