[FIX] cetmix_tower_server: fixed complete key ref computation #71
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ivs-cetmix
requested changes
Jun 29, 2024
| rec.key_ref_complete = ".".join( | ||
| ("#!cxtower", key_prefix, rec.key_ref, "!#") | ||
| ) | ||
| rec.key_ref_complete = "#!cxtower.%(prefix)s.%(ref)s!#" % { |
There was a problem hiding this comment.
This string is not translatable so better use f-string here. Because it's faster.
[REF] cetmix_tower_server: replaced plain formatting with an f-string
dmitriypaulov
force-pushed
the
14.0-t3504-cetmix_tower_server-fix_complete_key_ref
branch
from
f206b66 to
fe3f1b1
Compare
|
/ocabot merge nobump |
|
This PR looks fantastic, let's merge it! |
|
Congratulations, your PR was merged at 8523e48. Thanks a lot for contributing to cetmix. ❤️ |
CetmixGitDrone
deleted the
14.0-t3504-cetmix_tower_server-fix_complete_key_ref
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixed complete key ref computation