Skip to content

Commit

Permalink
UT refactoring
Browse files Browse the repository at this point in the history
  • Loading branch information
cesarParra committed Oct 29, 2024
1 parent 2723bd8 commit c42fae2
Show file tree
Hide file tree
Showing 8 changed files with 38 additions and 42 deletions.
19 changes: 18 additions & 1 deletion examples/changelog/docs/changelog.md
Original file line number Diff line number Diff line change
Expand Up @@ -49,4 +49,21 @@ These members have been added or modified.
### SolidService

- New Method: newMethod
- Removed Method: deprecatedMethod
- Removed Method: deprecatedMethod

## New or Removed Fields in Existing Objects

These custom fields have been added or removed.

### Event__c

- New Field: Description__c
- New Field: Tag_Line__c

### Price_Component__c

- New Field: Description__c

### Product__c

- New Field: Description__c
15 changes: 1 addition & 14 deletions src/core/changelog/__test__/generating-change-log.spec.ts
Original file line number Diff line number Diff line change
Expand Up @@ -7,6 +7,7 @@ import {
import { ChangeLogPageData, generateChangeLog } from '../generate-change-log';
import { assertEither } from '../../test-helpers/assert-either';
import { isSkip } from '../../shared/utils';
import { customObjectGenerator } from '../../test-helpers/test-data-builders';

const config = {
fileName: 'changelog',
Expand All @@ -18,20 +19,6 @@ const config = {
skipIfNoChanges: false,
};

function customObjectGenerator(
config: { deploymentStatus: string; visibility: string } = { deploymentStatus: 'Deployed', visibility: 'Public' },
) {
return `
<?xml version="1.0" encoding="UTF-8"?>
<CustomObject xmlns="http://soap.sforce.com/2006/04/metadata">
<deploymentStatus>${config.deploymentStatus}</deploymentStatus>
<description>test object for testing</description>
<label>MyTestObject</label>
<pluralLabel>MyFirstObjects</pluralLabel>
<visibility>${config.visibility}</visibility>
</CustomObject>`;
}

export const customField = `
<?xml version="1.0" encoding="UTF-8"?>
<CustomField xmlns="http://soap.sforce.com/2006/04/metadata">
Expand Down
1 change: 1 addition & 0 deletions src/core/changelog/templates/changelog-template.ts
Original file line number Diff line number Diff line change
Expand Up @@ -94,6 +94,7 @@ export const changelogTemplate = `
{{#each this.modifications}}
- {{this}}
{{/each}}
{{/each}}
{{/if}}
`.trim();
Original file line number Diff line number Diff line change
@@ -1,12 +1,12 @@
import { extendExpect } from './expect-extensions';
import {
customField,
customObjectGenerator,
generateDocs,
unparsedFieldBundleFromRawString,
unparsedObjectBundleFromRawString,
} from './test-helpers';
import { assertEither } from '../../test-helpers/assert-either';
import { customObjectGenerator } from '../../test-helpers/test-data-builders';

describe('Generates Custom Object documentation', () => {
beforeAll(() => {
Expand Down
8 changes: 2 additions & 6 deletions src/core/markdown/__test__/generating-docs.spec.ts
Original file line number Diff line number Diff line change
@@ -1,12 +1,8 @@
import { DocPageData, PostHookDocumentationBundle } from '../../shared/types';
import { extendExpect } from './expect-extensions';
import {
unparsedApexBundleFromRawString,
generateDocs,
unparsedObjectBundleFromRawString,
customObjectGenerator,
} from './test-helpers';
import { unparsedApexBundleFromRawString, generateDocs, unparsedObjectBundleFromRawString } from './test-helpers';
import { assertEither } from '../../test-helpers/assert-either';
import { customObjectGenerator } from '../../test-helpers/test-data-builders';

function aSingleDoc(result: PostHookDocumentationBundle): DocPageData {
expect(result.docs).toHaveLength(1);
Expand Down
8 changes: 2 additions & 6 deletions src/core/markdown/__test__/generating-reference-guide.spec.ts
Original file line number Diff line number Diff line change
@@ -1,14 +1,10 @@
import { extendExpect } from './expect-extensions';
import { pipe } from 'fp-ts/function';
import * as E from 'fp-ts/Either';
import {
unparsedApexBundleFromRawString,
generateDocs,
customObjectGenerator,
unparsedObjectBundleFromRawString,
} from './test-helpers';
import { unparsedApexBundleFromRawString, generateDocs, unparsedObjectBundleFromRawString } from './test-helpers';
import { ReferenceGuidePageData } from '../../shared/types';
import { assertEither } from '../../test-helpers/assert-either';
import { customObjectGenerator } from '../../test-helpers/test-data-builders';

describe('When generating the Reference Guide', () => {
beforeAll(() => {
Expand Down
14 changes: 0 additions & 14 deletions src/core/markdown/__test__/test-helpers.ts
Original file line number Diff line number Diff line change
Expand Up @@ -59,20 +59,6 @@ export function generateDocs(apexBundles: UnparsedSourceBundle[], config?: Parti
});
}

export function customObjectGenerator(
config: { deploymentStatus: string; visibility: string } = { deploymentStatus: 'Deployed', visibility: 'Public' },
) {
return `
<?xml version="1.0" encoding="UTF-8"?>
<CustomObject xmlns="http://soap.sforce.com/2006/04/metadata">
<deploymentStatus>${config.deploymentStatus}</deploymentStatus>
<description>test object for testing</description>
<label>MyTestObject</label>
<pluralLabel>MyFirstObjects</pluralLabel>
<visibility>${config.visibility}</visibility>
</CustomObject>`;
}

export const customField = `
<?xml version="1.0" encoding="UTF-8"?>
<CustomField xmlns="http://soap.sforce.com/2006/04/metadata">
Expand Down
13 changes: 13 additions & 0 deletions src/core/test-helpers/test-data-builders.ts
Original file line number Diff line number Diff line change
@@ -0,0 +1,13 @@
export function customObjectGenerator(
config: { deploymentStatus: string; visibility: string } = { deploymentStatus: 'Deployed', visibility: 'Public' },
) {
return `
<?xml version="1.0" encoding="UTF-8"?>
<CustomObject xmlns="http://soap.sforce.com/2006/04/metadata">
<deploymentStatus>${config.deploymentStatus}</deploymentStatus>
<description>test object for testing</description>
<label>MyTestObject</label>
<pluralLabel>MyFirstObjects</pluralLabel>
<visibility>${config.visibility}</visibility>
</CustomObject>`;
}

0 comments on commit c42fae2

Please sign in to comment.