Add more router tests #398
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hieronx
previously approved these changes
Aug 12, 2024
peculiarity
reviewed
Aug 13, 2024
| // multicall | ||
| uint256 fuel = estimateGas(); | ||
| bytes[] memory calls = new bytes[](2); | ||
| calls[0] = abi.encodeWithSelector(router.enableLockDepositRequest.selector, address(vault_), amount); |
There was a problem hiding this comment.
If this test will be used as an example for call encoding from the UI, it better uses abi.encodeCall. encodeCall makes args type check.
|
Coverage after merging router-tests into main will be
Coverage Report
|
|||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds another multicall test to reflect how the frontend will be using multicalls.
It also adds a test to verify users can call unlockDepositRequest while the asset is disallowed on the pool.