Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[MBI] In the table mod_bi_tmp_today_servicemetrics, use the same type as defined in mod_bi_servicemetrics #1517

Merged
merged 2 commits into from
Jul 15, 2024

Conversation

vuntz
Copy link
Member

@vuntz vuntz commented Jul 10, 2024

Description

We take data in the table mod_bi_servicemetrics and put them into mod_bi_tmp_today_servicemetrics.
The problem is that we don't use the same type for the id field so we have to change it.
The table is recreated each night so it will be fixed by a simple gorgone update.

Fixes MON-24657

This is centreon/centreon#2629 but moved to centreon-collect. Thanks @s-duret for the patch!

Type of change

  • Patch fixing an issue (non-breaking change)
  • New functionality (non-breaking change)
  • Breaking change (patch or feature) that might cause side effects breaking part of the Software
  • Updating documentation (missing information, typo...)

Target serie

  • 22.04.x
  • 22.10.x
  • 23.04.x
  • 23.10.x
  • 24.04.x
  • master

@vuntz vuntz requested a review from a team as a code owner July 10, 2024 09:09
@vuntz vuntz requested a review from Evan-Adam July 10, 2024 09:09
Copy link
Contributor

coderabbitai bot commented Jul 10, 2024

Important

Review skipped

Auto reviews are limited to specific labels.

Labels to auto review (1)
  • coderabbit

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.


Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

Share
Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>.
    • Generate unit testing code for this file.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    • @coderabbitai generate unit testing code for this file.
    • @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai generate interesting stats about this repository and render them as a table.
    • @coderabbitai show all the console.log statements in this repository.
    • @coderabbitai read src/utils.ts and generate unit testing code.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
    • @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (invoked as PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai full review to do a full review from scratch and review all the files again.
  • @coderabbitai summary to regenerate the summary of the PR.
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
  • @coderabbitai help to get help.

Additionally, you can add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.

CodeRabbit Configration File (.coderabbit.yaml)

  • You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
  • Please see the configuration documentation for more information.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

@vuntz
Copy link
Member Author

vuntz commented Jul 10, 2024

Note that we had approvals in centreon/centreon#2629 :-)

@vuntz vuntz merged commit 99a5cc9 into develop Jul 15, 2024
15 checks passed
@vuntz vuntz deleted the MON-24657 branch July 15, 2024 07:54
kduret pushed a commit that referenced this pull request Jul 19, 2024
…fined in mod_bi_servicemetrics (#1517)

* Use same type in all tables

* Update metric_id column type

---------

Co-authored-by: Stéphane Duret <[email protected]>
kduret pushed a commit that referenced this pull request Jul 19, 2024
…fined in mod_bi_servicemetrics (#1517)

* Use same type in all tables

* Update metric_id column type

---------

Co-authored-by: Stéphane Duret <[email protected]>
flcentreon pushed a commit that referenced this pull request Aug 20, 2024
* MON-12908: add centreon-mbi etl optimized (#220)

* enh(gorgone): use zmq ffi binding (#1057)

Co-authored-by: Kevin Duret <[email protected]>
Co-authored-by: Laurent Pinsivy <[email protected]>

* fix(mbi) change the type of metric_unit column (#1117)

* Empty-Commit

* Empty-Commit

* In the table mod_bi_tmp_today_servicemetrics, use the same type as defined in mod_bi_servicemetrics (#1517)

* Use same type in all tables

* Update metric_id column type

---------

Co-authored-by: Stéphane Duret <[email protected]>

---------

Co-authored-by: qgarnier <[email protected]>
Co-authored-by: Laurent Pinsivy <[email protected]>
Co-authored-by: Stéphane Duret <[email protected]>
Co-authored-by: Paul LOUIS THERESE <[email protected]>
Co-authored-by: pkippes <[email protected]>
Co-authored-by: tuntoja <[email protected]>
Co-authored-by: pkippes <[email protected]>
Co-authored-by: Vincent Untz <[email protected]>
flcentreon pushed a commit that referenced this pull request Aug 20, 2024
* MON-12908: add centreon-mbi etl optimized (#220)

* enh(gorgone): use zmq ffi binding (#1057)

Co-authored-by: Kevin Duret <[email protected]>
Co-authored-by: Laurent Pinsivy <[email protected]>

* fix(mbi) change the type of metric_unit column (#1117)

* Empty-Commit

* In the table mod_bi_tmp_today_servicemetrics, use the same type as defined in mod_bi_servicemetrics (#1517)

* Use same type in all tables

* Update metric_id column type

---------

Co-authored-by: Stéphane Duret <[email protected]>

---------

Co-authored-by: qgarnier <[email protected]>
Co-authored-by: Laurent Pinsivy <[email protected]>
Co-authored-by: Stéphane Duret <[email protected]>
Co-authored-by: Paul LOUIS THERESE <[email protected]>
Co-authored-by: pkippes <[email protected]>
Co-authored-by: tuntoja <[email protected]>
Co-authored-by: tuntoja <[email protected]>
Co-authored-by: Vincent Untz <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants