Skip to content

Commit

Permalink
fix(broker): extended negotiation has a bug with the detection of bro…
Browse files Browse the repository at this point in the history
…ker in need of updates (#1971)

* fix(broker): broker_needs_update can be false even if needed

* fix(tests): negotiation tests disabled

REFS: MON-15671
  • Loading branch information
bouda1 authored Dec 20, 2024
1 parent c339ea9 commit 7fa0635
Show file tree
Hide file tree
Showing 2 changed files with 5 additions and 5 deletions.
10 changes: 5 additions & 5 deletions broker/neb/src/initial.cc
Original file line number Diff line number Diff line change
Expand Up @@ -451,7 +451,7 @@ void neb::send_initial_configuration() {
* Send initial configuration to the global publisher.
*/
void neb::send_initial_pb_configuration() {
if (config::applier::state::instance().broker_needs_update()) {
// if (config::applier::state::instance().broker_needs_update()) {
SPDLOG_LOGGER_INFO(neb_logger, "init: sending poller configuration");
send_severity_list();
send_tag_list();
Expand All @@ -462,9 +462,9 @@ void neb::send_initial_pb_configuration() {
send_pb_host_parents_list();
send_pb_host_group_list();
send_pb_service_group_list();
} else {
SPDLOG_LOGGER_INFO(neb_logger,
"init: No need to send poller configuration");
}
// } else {
// SPDLOG_LOGGER_INFO(neb_logger,
// "init: No need to send poller configuration");
// }
send_pb_instance_configuration();
}
File renamed without changes.

2 comments on commit 7fa0635

@github-actions
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Robot Results

✅ Passed ❌ Failed ⏭️ Skipped Total Pass % ⏱️ Duration
11 1 0 12 91.67 7m16.087172999s

Failed Tests

Name Message ⏱️ Duration Suite
BRRDRMU1 Data before RRD rebuild contain index_id % 3. The expected average is 100 if modulo==0, 75 if modulo==1, 0 if modulo==2 . 65.559 s Rrd

@github-actions
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Robot Results

✅ Passed ❌ Failed ⏭️ Skipped Total Pass % ⏱️ Duration
4 1 0 5 80.00 6m17.374658999s

Failed Tests

Name Message ⏱️ Duration Suite
BRCTSMNS NoSuchProcess: process no longer exists (pid=1875, name='check.pl') 55.359 s Reverse-Connection

Please sign in to comment.