Skip to content

Commit

Permalink
Add dist folder to exports so webpack can see css file
Browse files Browse the repository at this point in the history
  • Loading branch information
dpilafian committed May 16, 2024
1 parent b992097 commit 9dd7ed2
Show file tree
Hide file tree
Showing 6 changed files with 20 additions and 15 deletions.
9 changes: 5 additions & 4 deletions .github/workflows/release-on-vtag.yaml
Original file line number Diff line number Diff line change
@@ -1,15 +1,16 @@
name: release
name: Create Release

on:
push:
tags:
- 'v*'

jobs:
build:
name: Create Release
runs-on: ubuntu-latest
steps:
- uses: actions/checkout@v4 #see: https://github.com/actions/checkout/releases
- uses: actions/create-release@v1
- uses: actions/checkout@v4 #see: https://github.com/actions/checkout/releases
- uses: actions/create-release@v1 #see: https://github.com/actions/create-release/releases
env:
GITHUB_TOKEN: ${{secrets.GITHUB_TOKEN}}
with:
Expand Down
5 changes: 3 additions & 2 deletions .github/workflows/run-spec-on-push.yaml
Original file line number Diff line number Diff line change
@@ -1,8 +1,9 @@
name: build
name: Build and Run Specifications

on: [push]

jobs:
build:
name: Run Specifications
runs-on: ubuntu-latest
steps:
- uses: actions/checkout@v4 #see: https://github.com/actions/checkout/releases
Expand Down
2 changes: 1 addition & 1 deletion README.md
Original file line number Diff line number Diff line change
Expand Up @@ -4,7 +4,7 @@ _A responsive CSS solution_
[![License:MIT](https://img.shields.io/badge/License-MIT-blue.svg)](https://github.com/center-key/hamburger-menu/blob/main/LICENSE.txt)
[![npm](https://img.shields.io/npm/v/hamburger-menu.svg)](https://www.npmjs.com/package/hamburger-menu)
[![Hits](https://data.jsdelivr.com/v1/package/npm/hamburger-menu/badge?style=rounded)](https://www.jsdelivr.com/package/npm/hamburger-menu)
[![Build](https://github.com/center-key/hamburger-menu/workflows/build/badge.svg)](https://github.com/center-key/hamburger-menu/actions/workflows/run-spec-on-push.yaml)
[![Build](https://github.com/center-key/hamburger-menu/actions/workflows/run-spec-on-push.yaml/badge.svg)](https://github.com/center-key/hamburger-menu/actions/workflows/run-spec-on-push.yaml)

Hamburger button menus should be used with caution as they can impair user interaction.
As they say, *"Out of sight, out of mind"*.
Expand Down
4 changes: 2 additions & 2 deletions docs/index.html
Original file line number Diff line number Diff line change
Expand Up @@ -10,7 +10,7 @@
<link rel=preconnect href=https://fonts.googleapis.com>
<link rel=preconnect href=https://fonts.gstatic.com crossorigin>
<link rel=stylesheet href=https://cdn.jsdelivr.net/npm/@fortawesome/[email protected]/css/all.min.css>
<link rel=stylesheet href=https://cdn.jsdelivr.net/npm/dna-engine@3.1/dist/dna-engine.css>
<link rel=stylesheet href=https://cdn.jsdelivr.net/npm/dna-engine@3.2/dist/dna-engine.css>
<link rel=stylesheet href=https://cdn.jsdelivr.net/npm/[email protected]/dist/reset.min.css>
<style>
body { text-align: center; color: gray; background-color: black; }
Expand All @@ -26,7 +26,7 @@
body >main >nav i.font-icon { font-size: 6rem; }
}
</style>
<script defer src=https://cdn.jsdelivr.net/npm/dna-engine@3.1/dist/dna-engine.min.js></script>
<script defer src=https://cdn.jsdelivr.net/npm/dna-engine@3.2/dist/dna-engine.min.js></script>
<script defer src=https://cdn.jsdelivr.net/npm/[email protected]/dist/lib-x.min.js></script>
<script defer src=hamburger-menu.js></script>
<script>globalThis.onerror = () => globalThis.document.body.style.background = 'pink';</script>
Expand Down
13 changes: 8 additions & 5 deletions package.json
Original file line number Diff line number Diff line change
Expand Up @@ -7,7 +7,10 @@
"module": "dist/hamburger-menu.js",
"browser": "dist/hamburger-menu.min.js",
"style": "dist/hamburger-menu.min.css",
"exports": "./dist/hamburger-menu.js",
"exports": {
".": "./dist/hamburger-menu.js",
"./": "./dist/"
},
"files": [
"dist"
],
Expand Down Expand Up @@ -77,14 +80,14 @@
"copy-file-util": "~1.2",
"copy-folder-util": "~1.1",
"csso-cli": "~4.0",
"dna-engine": "~3.1",
"dna-engine": "~3.2",
"jshint": "~2.13",
"mocha": "~10.3",
"replacer-util": "~1.2",
"mocha": "~10.4",
"replacer-util": "~1.3",
"rimraf": "~5.0",
"run-scripts-util": "~1.2",
"uglify-js": "~3.17",
"w3c-html-validator": "~1.7",
"w3c-html-validator": "~1.8",
"web-ignition": "~2.1"
}
}
2 changes: 1 addition & 1 deletion src/hamburger-menu.js
Original file line number Diff line number Diff line change
Expand Up @@ -13,7 +13,7 @@ const hamburgerMenu = {
// </aside>
// </nav>

version: '{{pkg.version}}',
version: '{{package.version}}',

selectItem(elem) {
const menuItem = elem.closest('li');
Expand Down

0 comments on commit 9dd7ed2

Please sign in to comment.