Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Shantae Half Genie Hero] New Graphics Pack #658

Open
wants to merge 4 commits into
base: master
Choose a base branch
from

Conversation

intra0
Copy link
Contributor

@intra0 intra0 commented Dec 12, 2024

updates the old v2 pack to v7 so it works on modern versions of cemu

the old v2 pack can be found here:
https://github.com/cemu-project/cemu_graphic_packs/blob/939a478799c13c5ed03e8decbf952f2a7ad02366/Source/ShantaeHGH/rules.txt

@intra0
Copy link
Contributor Author

intra0 commented Dec 12, 2024

oh btw, I will be going through and adding every mod into src through multiple pull request (and updating them all to version 6 if they were version 4)

Given I will be going through every mod
this would be a good time to do any style changes and be as pedantic as you want
I have the "Allow edits by maintainers" check box selected
if that doesn't do what I think it does, I can manually give you write permissions over my repository

so just to be clear, I give you full permission to make any commits you want to any branch in my repository for any pr.

@intra0
Copy link
Contributor Author

intra0 commented Dec 12, 2024

I will also be adding a #Credits: comment to every mod (again throughout multiple PR's)
for some mods it may not be necessary because the credits are already in the description but I'm still gonna add a credits field anyway just to keep every mod stylistically consistent

I am getting the credits by looking into the commit history for the specific game mods

@intra0
Copy link
Contributor Author

intra0 commented Dec 12, 2024

Almost Forgot screen shots. oops

2160p:
Screenshot_2024-12-12_14-17-42

1080p:
Screenshot_2024-12-12_14-19-30

360p:
Screenshot_2024-12-12_14-20-42

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant