[XCX] Fixes up sugested changes from last PR, updates max money mod #657
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fixes mispelling of compatible removes the `:` in the category names changes every `:float` to `:double` deletes credits comment at the bottom because it was already in the mods description
changes "work arround" to "workaround"
Moon jump usually means being able to infinitly jump this mod just makes you jump high, so the name is missleading
Makes it so the user can change the max money ammount
|
you also forgot to close #575 from the last PR |
intra0
commented
Dec 14, 2024
| $edgeThresholdMin:float = 0.0833 | ||
| $subPix:double = 0.75 | ||
| $edgeThreshold:double = 0.166 | ||
| $edgeThresholdMin:double = 0.0833 |
There was a problem hiding this comment.
I have tested :double, the mod works just the same, there is a noticable difference between native (mod off), fxaa, and aa disable.
so working exactly as intended
intra0
commented
Dec 14, 2024
| description = Increase horizontal and vertical velocity of jump (Vanilla values are 1.0 for both). | ||
| name = "Super High Jump!" | ||
| path = "Xenoblade Chronicles X/Mods/Physics/Super High Jump!" | ||
| description = Increase horizontal and vertical velocity of jump. |
There was a problem hiding this comment.
the (Vanilla values are 1.0 for both) isn't needed in the description because the x1.0 option for both distance and height have (default) in the name
500000 in hex is 0x7a120. its used in a li instruction so it gets trimmed to 0xa120 which is a negative intiger. all negative intigers produce the exact same effect in this mod. this change just make the rules.txt say what the mod actually does
is a convienence mod, sets your TP to max when booting the game, because it resets to 0 everytime you save & quit has some other fun options as well
intra0
changed the title
Going to make it, its own PR
there was recently someone who softlocked their save despite the warning that was already present, so making the warning even more visible. also adds a sentence explaing how forced = no works
intra0
changed the title
|
everything here looks good to me |
Tested and its working as intended. the non-custom options work the exact same as before, and the custom options both update in the enemy index, but also are very noticable in gameplay if you set them to the extreme 25% or 1000%
adds a x0 option to the exp mult so that when changing your level you can keep it there also stylictic changes to all the mult mods, and renaming the default camera distance mod also added a document to the change level mod
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Implements the suggested changes from the last PR
Renames moon jump to super high jump because the name moon jump is kinda misleading
the max money in the max money mod is now editable
adds a new TP mod that is a qol mod for the game, and also has some fun cheat options