-
Notifications
You must be signed in to change notification settings - Fork 640
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
nsyshid: Emulate Dimensions Toypad #1371
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
d2faf12
to
b409d5d
Compare
Will squash the commits once reviews have been done |
You don't have to. The Cemu repo has merge commits disabled so the options for merging PR's are squash or rebase. Usually squash is chosen so the individual commits do not enter the main tree. It might actually be helpful to keep the separate commits in the PR just in case. |
07af22c
to
6b1e6e2
Compare
6b1e6e2
to
1dbdbcc
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR aims to emulate the last mainstream toys-to-life peripheral, the Lego Dimensions Toypad. The Toypad is functionally very similar to the Disney Infinity Base, it has 2 endpoints, one for reading and one for writing, and all requests and responses are padded to 32 bytes.
The UI I have created functions mostly the same as the Skylander Portal and Infinity Base, but the layout is slightly different, to try to match the positions of a physical portal:
Users can Clear minifgures from the UI, Create either a new Character, or a 'Blank Tag' which can be used to store gadgets from the game, or Load an existing dump.
The game quite frequently requires figures to be moved to different positions on the Toypad, so I have added in a move button, which opens up a new UI window allowing users to quickly select a new position to move one of their loaded figures on to:
Any testing would be much appreciated, I have the game but a lot of different sections of the game have different ways to interact with the Toypad, so there is potential for some areas of the game to require slight variations to adding/removing responses etc.
For anyone interested, here is a video of the tool in action
This PR should close #1268.