feat: Submit `MsgUpdateClient` to tendermint light client #67

rootulp · 2024-12-23T19:43:05Z

Closes step two of #31.

A few changes in this PR, can split them into separate PRs if reviewers request:

Checkout submodules in CI workflows lint and test.
Sort makefile commands alphabetically. Add a new make relay command that does step 2.
Update README with an important step to apply a diff in solidity-ibc-eureka/justfile. The diff is needed so that the Tendermint light client on the EVM roll-up supports Groth16 and has the correct verifier key (from the celestia-prover)
Enable debug mode on Reth node (can revert if requested)
Add curl to the Celestia-prover for debugging purposes (can revert if requested)
Update solidity-ibc-eureka version
Modify the prover proto to return hex-encoded verifier keys. This made it easier to plumb directly into the EVM contract and Tendermint light client set-up (can revert if requested)
Add a line to celestia-prover README to show example usage of Info endpoint
Add a debug-txhash script to help debug failed EVM transactions (can revert if requested)
Refactor the extractDeployedContractAddresses to utils package so that it can be used in multiple places
Refactor the transfer script

Testing

I can't run the celestia-prover in Docker because #89 but if I run it locally, it works:

$ make relay
go run testing/demo/pkg/relay/main.go
Extracted deployed contract addresses: utils.ContractAddresses{ERC20:"0xa05915fd6e32a1aa7e67d800164cacb12487142d", Escrow:"0xc4515dd838dd640d6839933b33ff8d19640c1231", IBCStore:"0xf73bd8a7184bec941b3f9ef5e6f6df981e105535", ICS07Tendermint:"0xe53275a1fca119e1c5eeb32e7a72e54835a63936", ICS20Transfer:"0xb1c938f5ba4b3593377f399e12175e8db0c787ff", ICS26Router:"0x48fd1226d797400779bbfaf1706f5fb8da04ae91", ICSCore:"0x7e7ad18adc99b94d4c728fdf13d4de97b926a0d8"}
Getting celestia prover info...
Got celestia prover info. StateTransitionVerifierKey: 0x0081282e1279b92586a3330c1cd83a3f0910299bdc7be90ac1a24b2a0826523bInvoking icsCore.UpdateClient...
Transaction hash: 0x6370b144be660a5d8f798c45fe3f1942735e7a86063dc1834b61013f04de3b11
Block number: 170
Gas used: 289132
Logs: []
recvBlockNumber 170

~ $ simd query ibc channelv2 unreceived-packets channel-0 height: revision_height: "475" revision_number: "0" sequences: [] ~ $ simd query ibc channelv2 unreceived-packets channel-1 height: revision_height: "475" revision_number: "0" sequences: []

failed to request state transition proof: rpc error: code = Internal desc = error sending request for url (http://localhost:8545/)

rootulp · 2025-01-06T20:24:54Z

The request is hitting celestia-prover

2025-01-06 15:24:17 Got state transition request: Request { metadata: MetadataMap { headers: {"content-type": "application/grpc", "user-agent": "grpc-go/1.68.1", "te": "trailers", "grpc-timeout": "9979596u"} }, message: ProveStateTransitionRequest { client_id: "08-groth16-0" }, extensions: Extensions }

Getting this error

failed to request state transition proof: rpc error: code = Internal desc = Failed to parse client_id as EVM address: invalid string length

I think the client ID may need to be the SP1 contract address

rootulp · 2025-01-06T20:30:42Z

failed to request state transition proof: rpc error: code = Internal desc = error sending request for url (http://localhost:8545/)

rootulp · 2025-01-06T20:33:01Z

I think this line in the docker-compose may be incorrect

https://github.com/rootulp/celestia-zkevm-ibc-demo/blob/8bc7605469686c195e478e6fb0f7f04eedca22f3/docker-compose.yml#L107

rootulp · 2025-01-06T20:47:01Z

New error unlocked

failed to request state transition proof: rpc error: code = DeadlineExceeded desc = context deadline exceeded

rootulp · 2025-01-06T20:50:29Z

I made the celestia-prover crash. Logs from before the crash

2025-01-06 15:40:43 Prover Server listening on [::]:50051
2025-01-06 15:46:09 Got state transition request: Request { metadata: MetadataMap { headers: {"content-type": "application/grpc", "user-agent": "grpc-go/1.68.1", "te": "trailers", "grpc-timeout": "9988714u"} }, message: ProveStateTransitionRequest { client_id: "0x25cdbd2bf399341f8fee22ecdb06682ac81fdc37" }, extensions: Extensions }
2025-01-06 15:46:09 proving from height block::Height(5) to height Height { revision: 0, height: 5 }

Looks like it OOMed

		"OOMKilled": true,

docker-compose.yml

rootulp · 2025-01-23T20:40:38Z

The proof verifies off-chain:

20:48:33 DBG verifier done backend=groth16 curve=bn254 took=1.584417
proof verified ()

rootulp · 2025-01-23T21:15:48Z

The original public values are == to "reduced" public values, that is public values that have been modulo'ed the bn254 field limit. See https://www.diffchecker.com/rZxdMTKG/

rootulp · 2025-01-23T22:38:23Z

I switched to returning a hex-encoded verifier key from the celestia-prover. Now I'm getting a verifier key mismatch error again.

The logs

$ make relay2
go run testing/demo/pkg/relay-v2/main.go
addresses {0xb1c938f5ba4b3593377f399e12175e8db0c787ff 0xf73bd8a7184bec941b3f9ef5e6f6df981e105535 0x5bbab04b4740275903edb0fdb4e9d0e9a25abfef 0x25cdbd2bf399341f8fee22ecdb06682ac81fdc37 0x48fd1226d797400779bbfaf1706f5fb8da04ae91 0x7e7ad18adc99b94d4c728fdf13d4de97b926a0d8 0x70ac5980099d71f4cb561bbc0fcfef08aa6279ec}
Getting celestia prover info...
Got celestia prover info. State transition verifier key 0x0081282e1279b92586a3330c1cd83a3f0910299bdc7be90ac1a24b2a0826523b

To find the verifier key in the contract:

$ cast call 0x70ac5980099d71f4cb561bbc0fcfef08aa6279ec "getClient(string)(address)" "07-tendermint-0" http://localhost:8545
Warning: This is a nightly build of Foundry. It is recommended to use the latest stable version. Visit https://book.getfoundry.sh/announcements for more information.
To mute this warning set `FOUNDRY_DISABLE_NIGHTLY_WARNING` in your environment.

0x25CdBD2bf399341F8FEe22eCdB06682AC81fDC37
$
$ cast call 0x25CdBD2bf399341F8FEe22eCdB06682AC81fDC37 "UPDATE_CLIENT_PROGRAM_VKEY() (bytes32)" http://localhost:8545
Warning: This is a nightly build of Foundry. It is recommended to use the latest stable version. Visit https://book.getfoundry.sh/announcements for more information.
To mute this warning set `FOUNDRY_DISABLE_NIGHTLY_WARNING` in your environment.

0x0081282e1279b92586a3330c1cd83a3f0910299bdc7be90ac1a24b2a0826523b

The EVM error

result {"failed":true,"gas":47757,"returnValue":"d56bdc260081282e1279b92586a3330c1cd83a3f0910299bdc7be90ac1a24b2a0826523b81282e1279b92586a3330c1cd83a3f0910299bdc7be90ac1a24b2a0826523b00"

which maps to the error

| Error | VerificationKeyMismatch(bytes32,bytes32)                | 0xd56bdc26 |

rootulp · 2025-01-23T22:38:38Z

It looks like one of the verification keys is off by a byte

rootulp · 2025-01-23T22:47:20Z

Updating the client finally works:

make relay2

...

Invoking icsCore.UpdateClient...
icsCore.UpdateClient did not error
Transaction hash: 0xc19e6ed524224712c3a40127f5eb00d76c5d5def6030e70f87940e8a9958674f
Block number: 1408
Gas used: 289811
Logs: []
recvBlockNumber 1408

ninabarbakadze

great work, getting closer

testing/demo/pkg/utils/contract_addresses.go

testing/demo/pkg/setup/initialise_groth16_client.go

testing/demo/pkg/relay/main.go

ninabarbakadze · 2025-01-28T14:18:44Z

testing/demo/pkg/relay/main.go

+	ethereumRPC = "http://localhost:8545/"
+	// ethereumAddress is an address on the EVM chain.
+	// ethereumAddress = "0xaF9053bB6c4346381C77C2FeD279B17ABAfCDf4d"
+	// ethPrivateKey is the private key for ethereumAddress.


maybe we should specify that this is a faucet?

ninabarbakadze · 2025-01-28T14:58:25Z

testing/demo/pkg/relay/main.go

+	return txOpts
+}
+
+func getTxReciept(ctx context.Context, chain ethereum.Ethereum, hash ethcommon.Hash) *ethtypes.Receipt {


I think i added something similar in make setup script

Closes step two of #31. A few changes in this PR, can split them into separate PRs if reviewers request: 1. Checkout submodules in CI workflows lint and test. 2. Sort makefile commands alphabetically. Add a new `make relay` command that does step 2. 3. Update README with an important step to apply a diff in `solidity-ibc-eureka/justfile`. The diff is needed so that the Tendermint light client on the EVM roll-up supports Groth16 and has the correct verifier key (from the celestia-prover) 4. Enable debug mode on Reth node (can revert if requested) 5. Add `curl` to the Celestia-prover for debugging purposes (can revert if requested) 6. Update solidity-ibc-eureka version 7. Modify the prover proto to return hex-encoded verifier keys. This made it easier to plumb directly into the EVM contract and Tendermint light client set-up (can revert if requested) 8. Add a line to celestia-prover README to show example usage of `Info` endpoint 9. Add a debug-txhash script to help debug failed EVM transactions (can revert if requested) 10. Refactor the `extractDeployedContractAddresses` to utils package so that it can be used in multiple places 11. Refactor the `transfer` script I can't run the celestia-prover in Docker because #89 but if I run it locally, it works: ``` $ make relay go run testing/demo/pkg/relay/main.go Extracted deployed contract addresses: utils.ContractAddresses{ERC20:"0xa05915fd6e32a1aa7e67d800164cacb12487142d", Escrow:"0xc4515dd838dd640d6839933b33ff8d19640c1231", IBCStore:"0xf73bd8a7184bec941b3f9ef5e6f6df981e105535", ICS07Tendermint:"0xe53275a1fca119e1c5eeb32e7a72e54835a63936", ICS20Transfer:"0xb1c938f5ba4b3593377f399e12175e8db0c787ff", ICS26Router:"0x48fd1226d797400779bbfaf1706f5fb8da04ae91", ICSCore:"0x7e7ad18adc99b94d4c728fdf13d4de97b926a0d8"} Getting celestia prover info... Got celestia prover info. StateTransitionVerifierKey: 0x0081282e1279b92586a3330c1cd83a3f0910299bdc7be90ac1a24b2a0826523bInvoking icsCore.UpdateClient... Transaction hash: 0x6370b144be660a5d8f798c45fe3f1942735e7a86063dc1834b61013f04de3b11 Block number: 170 Gas used: 289132 Logs: [] recvBlockNumber 170 ```

rootulp added 2 commits December 23, 2024 14:38

feat: relayer binary

416f85a

todo

87c8b21

rootulp self-assigned this Dec 23, 2024

rootulp added 18 commits January 4, 2025 14:16

Merge branch 'main' into rp/relayer

bc194de

revert: separate relayer binary

b1eb748

query events associated with the tx

163b7cc

feat: query pending packet commitments

22286d5

refactor

d509523

start querying last trusted state root on EVM contract

d7221ca

more todos

4be1be9

make sense of todos

a592337

more cleanup

095f29c

debug: ICS07 light client has unique addresses

e5683ef

query client state latest height

be9ba01

refactor

fc893cf

start querying the celestia prover

154de99

debug: celestia prover fails to query EVM roll-up

653b53b

failed to request state transition proof: rpc error: code = Internal desc = error sending request for url (http://localhost:8545/)

cleanup

3604855

debug: add curl to celestia-prover to test connectivity

9f9f526

revert URL changes

195198f

fix: provide SP1 contract address as client ID in request

8bc7605

rootulp added 2 commits January 6, 2025 15:35

fix: one error, now another

36ca6dc

fix: connect celestia-prover to simapp

4cb4331

rootulp commented Jan 6, 2025

View reviewed changes

docker-compose.yml Outdated Show resolved Hide resolved

rootulp added 2 commits January 23, 2025 15:33

fix: lint

81e0b1d

refactor: accept txhash via CLI argument

9f1aee8

rootulp added 2 commits January 23, 2025 16:16

debug: verify that public values are within field

4ce4b7f

fix: use hex encoded verifier key

db27e82

fix: verifier key

4f8dd6c

rootulp added 9 commits January 24, 2025 09:54

refactor: rename relay2 to relay

1c08957

chore: remove unused deps

9578a3a

chore: remove log

0dd026e

refactor: remove debug-key

6aed08b

refactor: remove debug logs

a985bd8

refactor: stop using deprecated func

9c2a7f7

refactor: remove receive on EVM

b4b6a1c

docs: step to apply diff to justfile

1f1139f

Merge branch 'main' into rp/relayer

3d42d47

rootulp changed the title ~~feat: relayer~~ feat: Submit MsgUpdateClient to tendermint light client Jan 24, 2025

rootulp mentioned this pull request Jan 24, 2025

Complete the make transfer command #31

Open

6 tasks

docs: add step to modify docker-compose.yml

eb4cb2f

rootulp mentioned this pull request Jan 24, 2025

Include sp1 groth16 circuits in Docker image #89

Open

rootulp requested review from ninabarbakadze and cmwaters January 24, 2025 16:03

rootulp marked this pull request as ready for review January 24, 2025 16:03

ninabarbakadze approved these changes Jan 28, 2025

View reviewed changes

rootulp merged commit 4bad2b9 into celestiaorg:main Jan 28, 2025
3 checks passed

rootulp mentioned this pull request Feb 4, 2025

feat: sovereign integration #88

Merged

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

feat: Submit `MsgUpdateClient` to tendermint light client #67

feat: Submit `MsgUpdateClient` to tendermint light client #67

rootulp commented Dec 23, 2024 •

edited

Loading

rootulp commented Jan 6, 2025 •

edited

Loading

rootulp commented Jan 6, 2025

rootulp commented Jan 6, 2025

rootulp commented Jan 6, 2025

rootulp commented Jan 6, 2025 •

edited

Loading

rootulp commented Jan 23, 2025 •

edited

Loading

rootulp commented Jan 23, 2025

rootulp commented Jan 23, 2025

rootulp commented Jan 23, 2025

rootulp commented Jan 23, 2025

ninabarbakadze left a comment

ninabarbakadze Jan 28, 2025

ninabarbakadze Jan 28, 2025

feat: Submit MsgUpdateClient to tendermint light client #67

feat: Submit MsgUpdateClient to tendermint light client #67

Conversation

rootulp commented Dec 23, 2024 • edited Loading

Testing

rootulp commented Jan 6, 2025 • edited Loading

rootulp commented Jan 6, 2025

rootulp commented Jan 6, 2025

rootulp commented Jan 6, 2025

rootulp commented Jan 6, 2025 • edited Loading

rootulp commented Jan 23, 2025 • edited Loading

rootulp commented Jan 23, 2025

rootulp commented Jan 23, 2025

rootulp commented Jan 23, 2025

rootulp commented Jan 23, 2025

ninabarbakadze left a comment

Choose a reason for hiding this comment

ninabarbakadze Jan 28, 2025

Choose a reason for hiding this comment

ninabarbakadze Jan 28, 2025

Choose a reason for hiding this comment

feat: Submit `MsgUpdateClient` to tendermint light client #67

feat: Submit `MsgUpdateClient` to tendermint light client #67

rootulp commented Dec 23, 2024 •

edited

Loading

rootulp commented Jan 6, 2025 •

edited

Loading

rootulp commented Jan 6, 2025 •

edited

Loading

rootulp commented Jan 23, 2025 •

edited

Loading