Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor!(share/p2p): extend GetSharesByNamespaceRequest with Mode field #1899

Closed
wants to merge 5 commits into from

Conversation

vgonkivs
Copy link
Member

Overview

Extended GetSharesByNamespaceRequest allows passing what data should be retrieved.

Resolves #1837

Based on #1870

Checklist

  • New and updated code has appropriate documentation
  • New and updated code has new and/or updated testing
  • Required CI checks are passing
  • Visual proof for any user facing features like CLI or documentation updates
  • Linked issues closed with keywords

@vgonkivs vgonkivs added kind:break! Attached to breaking PRs area:blob kind:refactor Attached to refactoring PRs labels Mar 13, 2023
@vgonkivs vgonkivs self-assigned this Mar 13, 2023
@vgonkivs vgonkivs changed the title refactoring!(share/p2p): extend GetSharesByNamespaceRequest with Mode field refactor!(share/p2p): extend GetSharesByNamespaceRequest with Mode field Mar 13, 2023
@codecov-commenter
Copy link

Codecov Report

Merging #1899 (e81a0c7) into main (f99fb22) will increase coverage by 0.05%.
The diff coverage is 68.96%.

@@            Coverage Diff             @@
##             main    #1899      +/-   ##
==========================================
+ Coverage   57.31%   57.36%   +0.05%     
==========================================
  Files         242      243       +1     
  Lines       16149    16236      +87     
==========================================
+ Hits         9255     9313      +58     
- Misses       5946     5969      +23     
- Partials      948      954       +6     
Impacted Files Coverage Δ
share/p2p/shrexnd/server.go 61.90% <0.00%> (-1.51%) ⬇️
share/p2p/shrexnd/pb/share.pb.go 38.13% <48.57%> (+0.43%) ⬆️
share/ipld/get.go 92.23% <66.66%> (+0.08%) ⬆️
share/get.go 91.42% <75.00%> (+0.80%) ⬆️
share/ipld/namespace_data.go 79.26% <79.26%> (ø)
share/getters/utils.go 71.42% <100.00%> (-0.51%) ⬇️
share/p2p/shrexnd/client.go 57.48% <100.00%> (+0.33%) ⬆️

... and 4 files with indirect coverage changes

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@vgonkivs vgonkivs closed this Mar 26, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area:blob kind:break! Attached to breaking PRs kind:refactor Attached to refactoring PRs
Projects
No open projects
Status: Done
Development

Successfully merging this pull request may close these issues.

shrexnd: requesting proofs only on Client and Server
2 participants