Replace source of link to CCAO class dict in intro vignette #45
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jeancochrane
commented
Dec 5, 2024
Comment on lines
+221
to
+223
| ward_bound <- st_read( | ||
| "https://data.cityofchicago.org/resource/k9yb-bpqx.geojson" | ||
| ) %>% |
There was a problem hiding this comment.
Unrelated change I noticed while running tests on CI: It seems like the old URL no longer works. You can confirm this by visiting the non-export version of the URL, which returns no data: https://data.cityofchicago.org/api/geospatial/sp34-6z76
dfsnow
approved these changes
Dec 5, 2024
Comment on lines
+221
to
+223
| ward_bound <- st_read( | ||
| "https://data.cityofchicago.org/resource/k9yb-bpqx.geojson" | ||
| ) %>% |
jeancochrane
deleted the
jeancochrane/remove-deprecated-reference-to-ccao-class-dict
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We're removing
class_dict.csvfrom theccaopackage in ccao-data/ccao#34, so we have to change the reference to it in the intro vignette. We switch the reference to point to the equivalent seed in https://github.com/ccao-data/data-architecture/.