Pull neighborhood groups from a table in the data warehouse #107
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jeancochrane
changed the title
jeancochrane
commented
Mar 14, 2024
There was a problem hiding this comment.
This file is no longer necessary since the groups will be present in the data warehouse once ccao-data/data-architecture#343 lands.
Comment on lines
+103
to
+107
| INNER JOIN ( | ||
| SELECT nbhd, MAX(version) AS version | ||
| FROM location.neighborhood_group | ||
| GROUP BY nbhd | ||
| ) AS latest_group_version |
There was a problem hiding this comment.
Note that this join could also be extended to identify the version of the neighborhood groups that was used for a specific run; see the removed code in 70af482 for a sketch of what that would look like.
wagnerlmichael
approved these changes
Mar 14, 2024
There was a problem hiding this comment.
This looks good to me! I also read through https://github.com/ccao-data/data-architecture/pull/343/files and I like how it is open-ended for future development scenarios.
jeancochrane
deleted the
jeancochrane/pull-neighborhood-groups-from-data-warehouse
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR refactors
manual_flagging/flagging.pyto pull neighborhood group definitions from the data warehouse instead of a local Excel workbook.This is a companion PR to ccao-data/data-architecture#343 and should only be merged once that PR has been deployed.