Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add residential model parity updates #83

Merged
merged 7 commits into from
Jan 10, 2025

Conversation

@dfsnow dfsnow marked this pull request as ready for review January 9, 2025 19:09
@dfsnow dfsnow force-pushed the dfsnow/parity-updates branch from 93825d4 to ae3d20c Compare January 9, 2025 19:15
Copy link
Contributor

@jeancochrane jeancochrane left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good 👍🏻

Comment on lines +8 to +9
md5: 816b28ff1c68d17a9082d0dc839a85c0
size: 22844
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

[Nitpick, non-blocking] Same as the res model, it'd be nice if we could update the input hashes for downstream stages too to avoid a weird diff next time someone runs the model.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Updated in 6af9b01!

@dfsnow dfsnow merged commit dba072e into 2025-assessment-year Jan 10, 2025
4 checks passed
@dfsnow dfsnow deleted the dfsnow/parity-updates branch January 10, 2025 15:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants