-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update extract-chicago-permits
workflow to query Athena and output Excel workbooks
#13
Update extract-chicago-permits
workflow to query Athena and output Excel workbooks
#13
Conversation
This reverts commit fdd8aa7.
@@ -2,7 +2,7 @@ | |||
Chicago Permit Ingest Process - Automation | |||
|
|||
This script automates the current process for cleaning permit data from the Chicago Data Portal's Building Permits table | |||
and preparing it for upload to iasWorld via SmartFile. This involves fetching the data, cleaning up certain fields, | |||
and preparing it for upload to iasWorld via SmartFile. This involves fetching the data, cleaning up certain fields, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The changes in this file are exclusively removing stray whitespace, which you can confirm by hiding whitespace changes in the diff. I did this accidentally by opening and saving the file in my editor, but I figure it's probably good to remove this stray whitespace so I left the diff in.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
question (blocking): @jeancochrane Do you expect this run to output valid permits as well as invalid ones? Considering we're not diffing yet I'm surprised that all the permits specified are invalid.
Hmm that's pretty weird @dfsnow, I'll take a look! |
Good catch @dfsnow, I identified and fixed a couple bugs in 78702bc and the output is looking more reasonable:
Workflow run logs: https://github.com/ccao-data/extract-permits/actions/runs/7172832443/job/19530866528 |
This PR updates the
extract-chicago-permits
workflow to enable the changes made in #11, namely:Example successful workflow: https://github.com/ccao-data/extract-permits/actions/runs/7170976334/job/19525652232
Closes #12.