Clean up descriptions for parcel shape features so they are readable in model feature table #704
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…in model feature table
dfsnow
approved these changes
Jan 10, 2025
jeancochrane
deleted the
jeancochrane/clean-up-descriptions-for-shap-features
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
One small blocker for ccao-data/model-res-avm#315: When we pull descriptions for the
Features Usedtable in the model README, we grab the first sentence of the description (if a feature description contains multiple sentences). Two features,shp_parcel_mrr_area_ratioandshp_parcel_mrr_side_ratio, include Markdown-formatted links in the first sentence of their feature descriptions, but ourFeatures Usedtable output can't parse Markdown. This PR moves those links to the last sentence of the feature descriptions so that the descriptions are compatible with theFeatures Usedtable for the model.