Ensure socrata workflow inputs are handled correctly #699
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wrridgeway
commented
Jan 7, 2025
| @@ -333,6 +337,6 @@ def socrata_upload( | |||
| socrata_upload( | |||
| socrata_asset=os.getenv("SOCRATA_ASSET"), | |||
| overwrite=os.getenv("OVERWRITE"), | |||
| years=str(os.getenv("YEARS")).split(","), | |||
| years=str(os.getenv("YEARS")).replace(" ", "").split(","), | |||
There was a problem hiding this comment.
Without this entering "2023, 2024" in the github action will pass '2023' and ' 2024' and not actually pull 2024.
wrridgeway
commented
Jan 7, 2025
wrridgeway
commented
Jan 7, 2025
| @@ -204,7 +206,7 @@ def generate_groups(athena_asset, years=None, by_township=False): | |||
| if not years and by_township: | |||
| raise ValueError("Cannot set 'by_township' when 'years' is None") | |||
|
|
|||
| if years == "all": | |||
| if years == ["all"]: | |||
There was a problem hiding this comment.
the default 'all' is turned into ['all'] when inherited through the environment and this logic wasn't properly reacting to it.
wrridgeway
changed the title
jeancochrane
approved these changes
Jan 9, 2025
Co-authored-by: Jean Cochrane <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The default workflow value for years, 'all', was not being handled correctly since it becomes a list during ingest. Additionally, spaces in the years input could lead to year values not being handled correctly.
Since the columns that get updated currently depend on how the response from the API and the column names of the athena view that feeds the asset match up, it'd be nice to be able to confirm that all expected columns are in fact going to be updated.