Update vars dict ahead of 2025 model #35
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jeancochrane
commented
Jan 9, 2025
| @@ -508,3 +516,9 @@ qu_mlt_cd,card,card,meta_card_num,card_num,Card Number,meta,character,,, | |||
| ,,char_full_baths,char_full_baths,full_baths,Full Baths,char,numeric,,, | |||
| ,,strata_1,meta_strata_1,strata_1,Condominium Building Strata 1,meta,character,,, | |||
| ,,strata_2,meta_strata_2,strata_2,Condominium Building Strata 2,meta,character,,, | |||
| ,,shp_parcel_centroid_dist_ft_sd,shp_parcel_centroid_dist_ft_sd,parcel_centroid_dist_ft_sd,Standard Deviation Distance From Parcel Centroid to Vertices (Feet),shp,numeric,,, | |||
| ,,shp_parcel_edge_len_ft_sd,shp_parcel_edge_len_ft_sd,parcel_edge_len_ft_sd,Standard Deviation Parcel Edge Length (Feet),shp,numeric,,, | |||
| ,,shp_parcel_interior_angle_sd,shp_parcel_interior_angle_sd,parcel_interior_angle_sd,Standard Deviation Parcel Interior Angle (Degrees),shp,numeric,,, | |||
There was a problem hiding this comment.
Are these angles in degrees, or radians?
There was a problem hiding this comment.
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #35 +/- ##
=========================================
Coverage 100.00% 100.00%
=========================================
Files 6 6
Lines 382 365 -17
=========================================
- Hits 382 365 -17 ☔ View full report in Codecov by Sentry. |
dfsnow
approved these changes
Jan 9, 2025
| @@ -508,3 +516,9 @@ qu_mlt_cd,card,card,meta_card_num,card_num,Card Number,meta,character,,, | |||
| ,,char_full_baths,char_full_baths,full_baths,Full Baths,char,numeric,,, | |||
| ,,strata_1,meta_strata_1,strata_1,Condominium Building Strata 1,meta,character,,, | |||
| ,,strata_2,meta_strata_2,strata_2,Condominium Building Strata 2,meta,character,,, | |||
| ,,shp_parcel_centroid_dist_ft_sd,shp_parcel_centroid_dist_ft_sd,parcel_centroid_dist_ft_sd,Standard Deviation Distance From Parcel Centroid to Vertices (Feet),shp,numeric,,, | |||
| ,,shp_parcel_edge_len_ft_sd,shp_parcel_edge_len_ft_sd,parcel_edge_len_ft_sd,Standard Deviation Parcel Edge Length (Feet),shp,numeric,,, | |||
| ,,shp_parcel_interior_angle_sd,shp_parcel_interior_angle_sd,parcel_interior_angle_sd,Standard Deviation Parcel Interior Angle (Degrees),shp,numeric,,, | |||
There was a problem hiding this comment.
This was referenced Jan 10, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR updates the
ccao::vars_dictobject to incorporate all of the features we're currently using in the res and condo models.Since the CSV diff is a bit hard to read, here's a table of the rows that this PR adds: