Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix is_corner_lot athena name #20

Merged
merged 1 commit into from
Mar 1, 2024

Conversation

wrridgeway
Copy link
Member

@wrridgeway wrridgeway commented Feb 29, 2024

I incorrectly assumed the ccao db was in our dag and that is_corner_lot would exist as a column name because of that. Since the ccao db is not in the dag, this column only appears as ccao_is_corner_lot and needs to be updated in vars_dict.

@wrridgeway wrridgeway self-assigned this Feb 29, 2024
@wrridgeway wrridgeway linked an issue Feb 29, 2024 that may be closed by this pull request
Copy link

codecov bot commented Feb 29, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 100.00%. Comparing base (57ea1bb) to head (91f9114).

Additional details and impacted files
@@            Coverage Diff            @@
##            master       #20   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files            6         6           
  Lines          382       382           
=========================================
  Hits           382       382           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@wrridgeway wrridgeway marked this pull request as ready for review February 29, 2024 20:20
@wrridgeway wrridgeway requested a review from a team as a code owner February 29, 2024 20:20
@wrridgeway wrridgeway merged commit 779024f into master Mar 1, 2024
12 checks passed
@wrridgeway wrridgeway deleted the 19-fix-is_corner_lot-athena-name branch March 1, 2024 16:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Fix is_corner_lot athena name
2 participants