Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update names and adjectives #14

Merged
merged 2 commits into from
Dec 8, 2023
Merged

Update names and adjectives #14

merged 2 commits into from
Dec 8, 2023

Conversation

dfsnow
Copy link
Member

@dfsnow dfsnow commented Dec 8, 2023

No description provided.

@dfsnow dfsnow requested a review from a team as a code owner December 8, 2023 06:35
Copy link

codecov bot commented Dec 8, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (250586c) 100.00% compared to head (e39aa2c) 100.00%.

Additional details and impacted files
@@            Coverage Diff            @@
##            master       #14   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files            6         6           
  Lines          382       382           
=========================================
  Hits           382       382           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Contributor

@jeancochrane jeancochrane left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for taking on this chore!

"michael"
"michael",
"caroline",
"matt" # again
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

[Suggestion, non-blocking] Maybe matthew to distinguish this name from the one above?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Changed in e39aa2c!

@@ -35,6 +38,7 @@ left <- c(
"epic",
"exciting",
"fancy-free",
"fecund",
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

[Nitpick, non-blocking] I'm on the fence about this one 😅 From the top-level OED summary:

fecund, adj.
Of animals, the earth, etc.: Capable of producing offspring or vegetable growth abundantly; prolific, fertile.

According to Merriam-Webster, "prolific" is the most apt synonym, but I feel hesitant about the connection to "fertile" in the OED definition!

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good thinking, removed in e39aa2c

@dfsnow dfsnow merged commit ad3b1c4 into master Dec 8, 2023
12 checks passed
@dfsnow dfsnow deleted the dfsnow/add-intern-names branch December 8, 2023 19:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants