-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update names and adjectives #14
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #14 +/- ##
=========================================
Coverage 100.00% 100.00%
=========================================
Files 6 6
Lines 382 382
=========================================
Hits 382 382 ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for taking on this chore!
data-raw/ccao_ids.R
Outdated
"michael" | ||
"michael", | ||
"caroline", | ||
"matt" # again |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
[Suggestion, non-blocking] Maybe matthew
to distinguish this name from the one above?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Changed in e39aa2c!
data-raw/ccao_ids.R
Outdated
@@ -35,6 +38,7 @@ left <- c( | |||
"epic", | |||
"exciting", | |||
"fancy-free", | |||
"fecund", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
[Nitpick, non-blocking] I'm on the fence about this one 😅 From the top-level OED summary:
fecund, adj.
Of animals, the earth, etc.: Capable of producing offspring or vegetable growth abundantly; prolific, fertile.
According to Merriam-Webster, "prolific" is the most apt synonym, but I feel hesitant about the connection to "fertile" in the OED definition!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Good thinking, removed in e39aa2c
No description provided.