Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add hie vars back to vars_dict.csv #13

Closed
wants to merge 1 commit into from

Conversation

wrridgeway
Copy link
Member

@wrridgeway wrridgeway commented Nov 16, 2023

hie_ variables were removed from the variable dictionary at some point, but we need them for the ingest stage of the pipeline

@wrridgeway wrridgeway linked an issue Nov 16, 2023 that may be closed by this pull request
Copy link

codecov bot commented Nov 16, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (250586c) 100.00% compared to head (9651655) 100.00%.

❗ Current head 9651655 differs from pull request most recent head 42f7a73. Consider uploading reports for the commit 42f7a73 to get more accurate results

Additional details and impacted files
@@            Coverage Diff            @@
##            master       #13   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files            6         6           
  Lines          382       382           
=========================================
  Hits           382       382           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@wrridgeway wrridgeway marked this pull request as ready for review November 16, 2023 17:33
@wrridgeway wrridgeway requested a review from a team as a code owner November 16, 2023 17:33
@jeancochrane
Copy link
Contributor

I don't have enough context to be able to approve this, but here's a refresher on when/why we removed these variables: #6 (comment)

@wrridgeway
Copy link
Member Author

wrridgeway commented Nov 16, 2023

Hmm... thanks @jeancochrane. @dfsnow If we explicitly don't want these variables in the vars_dict, we can just exclude them from re-coding in the pipeline rather than adding them back:

mutate(across(
    !starts_with("sv_"),
    ~ recode_column_type(.x, cur_column())
  ))

becomes

mutate(across(
    !starts_with(c("sv_", "hie_")),
    ~ recode_column_type(.x, cur_column())
  ))

@wrridgeway wrridgeway closed this Nov 16, 2023
@wrridgeway wrridgeway reopened this Nov 16, 2023
@dfsnow
Copy link
Member

dfsnow commented Nov 16, 2023

@wrridgeway Let's just go with the in-script exclusion rather than rewriting the dict.

@dfsnow dfsnow closed this Nov 16, 2023
@wrridgeway wrridgeway deleted the 12-add-hie_num_active-to-vars_dict branch November 16, 2023 19:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add hie_num_active to vars_dict
3 participants