Update pre-commit action to cache R additional_dependencies
#36
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dfsnow
approved these changes
Jan 11, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
While working on a PR that uses
additional_dependenciesfor a local R pre-commit hook, I noticed that workflow runs with a cache hit were failing with an error indicating that the dependencies were not installed, while non-cached runs were succeeding. After some debugging, I realized that pre-commit symlinks to the~/.local/share/renv/cachefolder for local hooks. This PR adds that directory to the workflow cache so that we can properly pull dependencies in case of cache hit.See here for an example of a cached run that succeeded.