Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve spade test #9

Open
wants to merge 2 commits into
base: spadecutoff
Choose a base branch
from
Open

Improve spade test #9

wants to merge 2 commits into from

Conversation

vict0rsch
Copy link
Contributor

@51N84D when working with paths, I really strongly advise you stick with pathlib which is part of Python's standard libraries and really more robust than handling strings (if you're ever checking that a user input does or does not end with a /, you're doing it wrong :p )

Also, when writing to a directory, check that it exists first

@vict0rsch vict0rsch requested a review from 51N84D April 14, 2020 15:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant