Merge pull request #21 from cb-cloud/feature/guard-size-change-detection

Guard size change detection
cb-cloud · Jul 1, 2022 · ec04ed3 · ec04ed3
2 parents d33e05d + 1ca3615
commit ec04ed3
Show file tree

Hide file tree

Showing 4 changed files with 8 additions and 2 deletions.
diff --git a/CHANGELOG.md b/CHANGELOG.md
@@ -1,3 +1,8 @@
+## 1.1.2
+### FIX
+- Prevent some `Completer` error.
+  - When the size of a notification was changed unexpectedly, a `Future already completed.` error could occur.
+
 ## 1.1.1
 ### FIX
 - Fixed warnings for Flutter3.0.0 

diff --git a/example/pubspec.lock b/example/pubspec.lock
@@ -66,7 +66,7 @@ packages:
       path: ".."
       relative: true
     source: path
-    version: "1.1.1"
+    version: "1.1.2"
   matcher:
     dependency: transitive
     description:

diff --git a/lib/src/in_app_notification.dart b/lib/src/in_app_notification.dart
@@ -135,6 +135,7 @@ class _NotificationController extends InheritedWidget {
           width: state.screenSize.width,
           child: SizeListenableContainer(
             onSizeChanged: (size) {
+              if (state.notificationSizeCompleter.isCompleted) return;
               final topPadding = MediaQuery.of(context).viewPadding.top;
               state.notificationSizeCompleter
                   .complete(size + Offset(0, topPadding));

diff --git a/pubspec.yaml b/pubspec.yaml
@@ -1,6 +1,6 @@
 name: in_app_notification
 description: A Flutter package to show custom in-app notification with any Widgets.
-version: 1.1.1
+version: 1.1.2
 repository: https://github.com/cb-cloud/flutter_in_app_notification
 
 environment: