-
-
Notifications
You must be signed in to change notification settings - Fork 58
Conversation
Do we want to set the border colour explicitly / is it already subtext? |
border seems to be set to none, |
I got that from this command |
Hmm. We can always revisit that at a later date, seems good for now 👍 |
Blocked on v1 though. |
Just looking into it, because it's set to none, its breaking. |
Oh the patch is also failing because |
&.background { | ||
// background-color needs to be set this way otherwise it gets drawn twice | ||
// see https://bugzilla.gnome.org/show_bug.cgi?id=736155 for details. | ||
- background-color: transparentize(black, 0.2); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I don't think these colours are right for mocha etc. 750 is mantle, and i think we just use $white for text?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
$white
is a hardcoded value
gtk/patches/colloid/palette.tera
Line 108 in 4173b70
+$white: #eff1f5; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sure, but white
and $white
are two very different things, you have the former in this case? Did you mean to put the latter in?
&.background { | ||
// background-color needs to be set this way otherwise it gets drawn twice | ||
// see https://bugzilla.gnome.org/show_bug.cgi?id=736155 for details. | ||
- background-color: transparentize(black, 0.2); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sure, but white
and $white
are two very different things, you have the former in this case? Did you mean to put the latter in?
No description provided.