-
-
Notifications
You must be signed in to change notification settings - Fork 57
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just little things here and there, pretty great for a first draft. Thanks for taking the time to write it up.
We discussed this earlier but a high-level architecture diagram would be nice outlining the stages. Something simple in mermaid would suffice. (Doesn't need to be in this PR)
Yeah, we can provide the diagram later. I'll probably want to link to code there, meaning #215 should land first 👍 There is a little duplication from the contributing guide regarding patches, but I think that's fine? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There is a little duplication from the contributing guide regarding patches, but I think that's fine?
Yeah should be fine, I don't see the patching system information changing in the near future since that would require us moving off colloid
[![Mend Renovate](https://app.renovatebot.com/images/banner.svg)](https://renovatebot.com) This PR contains the following updates: | Package | Update | Change | |---|---|---| | [catppuccin/gtk](https://togithub.com/catppuccin/gtk) | major | `v0.7.5` -> `v1.0.3` | --- > [!WARNING] > Some dependencies could not be looked up. Check the Dependency Dashboard for more information. --- ### Release Notes <details> <summary>catppuccin/gtk (catppuccin/gtk)</summary> ### [`v1.0.3`](https://togithub.com/catppuccin/gtk/releases/tag/v1.0.3) [Compare Source](https://togithub.com/catppuccin/gtk/compare/v1.0.2...v1.0.3) > \[!IMPORTANT] > **This will be the last release before this repository is archived.** To understand why, see [#​262](https://togithub.com/catppuccin/gtk/issues/262). ##### Performance Improvements - improving performance, layout ([#​215](https://togithub.com/catppuccin/gtk/issues/215)) ([cadc3e2](https://togithub.com/catppuccin/gtk/commit/cadc3e2ac24f93c6641f9f87ee5d044433c65ce7)) ### [`v1.0.2`](https://togithub.com/catppuccin/gtk/releases/tag/v1.0.2) [Compare Source](https://togithub.com/catppuccin/gtk/compare/v.1.0.0...v1.0.2) Skipped 1.0.1 because of troubles with the release-please integration. ##### Bug Fixes - alt tab menu ([#​209](https://togithub.com/catppuccin/gtk/issues/209)) ([cae57c8](https://togithub.com/catppuccin/gtk/commit/cae57c80f81fd1cc40fab2655109b09fa97103b9)) ### [`v1.0.0`](https://togithub.com/catppuccin/gtk/releases/tag/v1.0.0) [Compare Source](https://togithub.com/catppuccin/gtk/compare/v0.7.5...v.1.0.0) This marks the first stable release after the massive refactorings we did. Great work. #### What's Changed - build: new build system by [@​nullishamy](https://togithub.com/nullishamy) in [https://github.com/catppuccin/gtk/pull/178](https://togithub.com/catppuccin/gtk/pull/178) - docs: update readme to support new build system ([#​183](https://togithub.com/catppuccin/gtk/issues/183)) by [@​nullishamy](https://togithub.com/nullishamy) in [https://github.com/catppuccin/gtk/pull/185](https://togithub.com/catppuccin/gtk/pull/185) - refactor: build scripts by [@​nullishamy](https://togithub.com/nullishamy) in [https://github.com/catppuccin/gtk/pull/186](https://togithub.com/catppuccin/gtk/pull/186) - docs(README): overhaul with updated information by [@​nullishamy](https://togithub.com/nullishamy) in [https://github.com/catppuccin/gtk/pull/187](https://togithub.com/catppuccin/gtk/pull/187) - chore: Configure Renovate by [@​renovate](https://togithub.com/renovate) in [https://github.com/catppuccin/gtk/pull/184](https://togithub.com/catppuccin/gtk/pull/184) - fix: use `v1.0.0-rc1` for the install script by [@​nullishamy](https://togithub.com/nullishamy) in [https://github.com/catppuccin/gtk/pull/192](https://togithub.com/catppuccin/gtk/pull/192) - refactor: reduce repeated code by [@​isabelroses](https://togithub.com/isabelroses) in [https://github.com/catppuccin/gtk/pull/198](https://togithub.com/catppuccin/gtk/pull/198) - docs: improve and fix the readme by [@​somerand0mcat](https://togithub.com/somerand0mcat) in [https://github.com/catppuccin/gtk/pull/197](https://togithub.com/catppuccin/gtk/pull/197) - fix: argument `--accent` behaves like the old argument by [@​isabelroses](https://togithub.com/isabelroses) in [https://github.com/catppuccin/gtk/pull/200](https://togithub.com/catppuccin/gtk/pull/200) - fix: use rc2 in the install script by [@​nullishamy](https://togithub.com/nullishamy) in [https://github.com/catppuccin/gtk/pull/201](https://togithub.com/catppuccin/gtk/pull/201) - fix: actually apply our accents by [@​nullishamy](https://togithub.com/nullishamy) in [https://github.com/catppuccin/gtk/pull/199](https://togithub.com/catppuccin/gtk/pull/199) - fix: disallow 'all' in install.py accent options by [@​nullishamy](https://togithub.com/nullishamy) in [https://github.com/catppuccin/gtk/pull/205](https://togithub.com/catppuccin/gtk/pull/205) - ci: build in PRs by [@​nullishamy](https://togithub.com/nullishamy) in [https://github.com/catppuccin/gtk/pull/202](https://togithub.com/catppuccin/gtk/pull/202) - feat: xfwm4 asset generation by [@​nullishamy](https://togithub.com/nullishamy) in [https://github.com/catppuccin/gtk/pull/206](https://togithub.com/catppuccin/gtk/pull/206) - chore: update install script to rc3 by [@​nullishamy](https://togithub.com/nullishamy) in [https://github.com/catppuccin/gtk/pull/207](https://togithub.com/catppuccin/gtk/pull/207) - docs: add resources to contributing guide by [@​nullishamy](https://togithub.com/nullishamy) in [https://github.com/catppuccin/gtk/pull/211](https://togithub.com/catppuccin/gtk/pull/211) - docs: add new build reqs in by [@​nullishamy](https://togithub.com/nullishamy) in [https://github.com/catppuccin/gtk/pull/208](https://togithub.com/catppuccin/gtk/pull/208) - fix: installation by [@​nullishamy](https://togithub.com/nullishamy) in [https://github.com/catppuccin/gtk/pull/210](https://togithub.com/catppuccin/gtk/pull/210) - docs: upstreaming procedure by [@​nullishamy](https://togithub.com/nullishamy) in [https://github.com/catppuccin/gtk/pull/219](https://togithub.com/catppuccin/gtk/pull/219) - docs: flatpak guide by [@​somerand0mcat](https://togithub.com/somerand0mcat) in [https://github.com/catppuccin/gtk/pull/221](https://togithub.com/catppuccin/gtk/pull/221) - chore: issue template by [@​nullishamy](https://togithub.com/nullishamy) in [https://github.com/catppuccin/gtk/pull/222](https://togithub.com/catppuccin/gtk/pull/222) - feat: reintroduce black tweak as OLED-esque variant by [@​nullishamy](https://togithub.com/nullishamy) in [https://github.com/catppuccin/gtk/pull/213](https://togithub.com/catppuccin/gtk/pull/213) - fix(patches): allow to work on windows by [@​isabelroses](https://togithub.com/isabelroses) in [https://github.com/catppuccin/gtk/pull/226](https://togithub.com/catppuccin/gtk/pull/226) - chore: update install script to rc4 by [@​nullishamy](https://togithub.com/nullishamy) in [https://github.com/catppuccin/gtk/pull/227](https://togithub.com/catppuccin/gtk/pull/227) - fix: patches by [@​isabelroses](https://togithub.com/isabelroses) in [https://github.com/catppuccin/gtk/pull/229](https://togithub.com/catppuccin/gtk/pull/229) - ci: exit with non zero exit code when a build fails by [@​nullishamy](https://togithub.com/nullishamy) in [https://github.com/catppuccin/gtk/pull/231](https://togithub.com/catppuccin/gtk/pull/231) - fix: allow all accents to be used by [@​nullishamy](https://togithub.com/nullishamy) in [https://github.com/catppuccin/gtk/pull/232](https://togithub.com/catppuccin/gtk/pull/232) - chore: update install script to rc5 by [@​nullishamy](https://togithub.com/nullishamy) in [https://github.com/catppuccin/gtk/pull/233](https://togithub.com/catppuccin/gtk/pull/233) - docs: architecture docs by [@​nullishamy](https://togithub.com/nullishamy) in [https://github.com/catppuccin/gtk/pull/242](https://togithub.com/catppuccin/gtk/pull/242) - fix: add build suffix by [@​nullishamy](https://togithub.com/nullishamy) in [https://github.com/catppuccin/gtk/pull/241](https://togithub.com/catppuccin/gtk/pull/241) - fix: xfwm4 assets by [@​nullishamy](https://togithub.com/nullishamy) in [https://github.com/catppuccin/gtk/pull/240](https://togithub.com/catppuccin/gtk/pull/240) - fix: titlebars should be mantle not crust by [@​nullishamy](https://togithub.com/nullishamy) in [https://github.com/catppuccin/gtk/pull/238](https://togithub.com/catppuccin/gtk/pull/238) #### New Contributors - [@​renovate](https://togithub.com/renovate) made their first contribution in [https://github.com/catppuccin/gtk/pull/184](https://togithub.com/catppuccin/gtk/pull/184) **Full Changelog**: catppuccin/gtk@v0.7.5...v1.0.0 </details> --- ### Configuration 📅 **Schedule**: Branch creation - "after 4pm on thursday" in timezone America/Los_Angeles, Automerge - At any time (no schedule defined). 🚦 **Automerge**: Disabled by config. Please merge this manually once you are satisfied. ♻ **Rebasing**: Whenever PR is behind base branch, or you tick the rebase/retry checkbox. 🔕 **Ignore**: Close this PR and you won't be reminded about this update again. --- - [ ] <!-- rebase-check -->If you want to rebase/retry this PR, check this box --- This PR has been generated by [Mend Renovate](https://www.mend.io/free-developer-tools/renovate/). View repository job log [here](https://developer.mend.io/github/scottames/dots). <!--renovate-debug:eyJjcmVhdGVkSW5WZXIiOiIzNy4zNzcuOCIsInVwZGF0ZWRJblZlciI6IjM3LjM3Ny44IiwidGFyZ2V0QnJhbmNoIjoibWFpbiIsImxhYmVscyI6WyJkZXBlbmRlbmNpZXMiXX0=--> Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
No description provided.