analyzer: remove redundant if stmts

catenacyber · Nov 19, 2024 · 6843b28 · 6843b28
1 parent 7f3ce4e
commit 6843b28
Showing 1 changed file with 9 additions and 17 deletions.
diff --git a/analyzer/analyzer.go b/analyzer/analyzer.go
@@ -99,31 +99,23 @@ func (n *perfSprint) run(pass *analysis.Pass) (interface{}, error) {
 			fn    string
 			verb  string
 			value ast.Expr
-			err   error
+			err error
 		)
 		switch {
-		case calledObj == fmtErrorfObj && len(call.Args) == 1:
-			if n.errorf {
-				fn = "fmt.Errorf"
-				verb = "%s"
-				value = call.Args[0]
-			} else {
-				return
-			}
+		case calledObj == fmtErrorfObj && len(call.Args) == 1 && n.errorf:
+			fn = "fmt.Errorf"
+			verb = "%s"
+			value = call.Args[0]
 
 		case calledObj == fmtSprintObj && len(call.Args) == 1:
 			fn = "fmt.Sprint"
 			verb = "%v"
 			value = call.Args[0]
 
-		case calledObj == fmtSprintfObj && len(call.Args) == 1:
-			if n.sprintf1 {
-				fn = "fmt.Sprintf"
-				verb = "%s"
-				value = call.Args[0]
-			} else {
-				return
-			}
+		case calledObj == fmtSprintfObj && len(call.Args) == 1 && n.sprintf1:
+			fn = "fmt.Sprintf"
+			verb = "%s"
+			value = call.Args[0]
 
 		case calledObj == fmtSprintfObj && len(call.Args) == 2:
 			verbLit, ok := call.Args[0].(*ast.BasicLit)