-
Notifications
You must be signed in to change notification settings - Fork 471
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Reproduce - doc2query document expansion #2642
Conversation
hi @b8zhong - sorry, I do want to merge this - just haven't gotten a chance to yet... |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #2642 +/- ##
=========================================
Coverage 67.11% 67.11%
Complexity 1190 1190
=========================================
Files 182 182
Lines 11354 11354
Branches 1369 1369
=========================================
Hits 7620 7620
Misses 3230 3230
Partials 504 504 ☔ View full report in Codecov by Sentry. |
Np; there's still a few dead links I should prolly remove. Is every Dropbox link dead or something? |
Yes, the Dropbox links are defunct, please remove. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Minor nit, and then I can merge.
Update Doc + Scripts for doc2query
Summary of Changes
1. Dropbox Links
2. Eval Commands
target/appassembler/bin/trec_eval
and IndexCollection (tobin/run.sh
):trec_eval
, the results don't change though3. Retrieval
tools/scripts/msmarco/retrieve.py
is defunct, so I replaced withpyserini.search.lucene
module: