Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Token state check with Y #468

Merged
merged 2 commits into from
Mar 12, 2024
Merged

Token state check with Y #468

merged 2 commits into from
Mar 12, 2024

Conversation

callebtc
Copy link
Collaborator

@callebtc callebtc commented Mar 7, 2024

This PR fixes the check_proofs_state method in the Ledger class. It updates the method to use the Y attribute of the Proof objects instead of the secret attribute. This change ensures that the method works correctly with the updated ProofState model.

Implements change in NUT-07: cashubtc/nuts#93

Copy link

codecov bot commented Mar 7, 2024

Codecov Report

Attention: Patch coverage is 47.91667% with 25 lines in your changes are missing coverage. Please review.

Project coverage is 68.63%. Comparing base (ff1e759) to head (30ee04a).

Files Patch % Lines
cashu/mint/crud.py 10.00% 18 Missing ⚠️
cashu/mint/ledger.py 75.00% 2 Missing ⚠️
cashu/mint/verification.py 83.33% 2 Missing ⚠️
cashu/mint/router.py 0.00% 1 Missing ⚠️
cashu/mint/router_deprecated.py 0.00% 1 Missing ⚠️
cashu/wallet/wallet.py 75.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #468      +/-   ##
==========================================
- Coverage   68.82%   68.63%   -0.19%     
==========================================
  Files          74       74              
  Lines        6633     6648      +15     
==========================================
- Hits         4565     4563       -2     
- Misses       2068     2085      +17     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@callebtc callebtc merged commit 150195d into main Mar 12, 2024
16 checks passed
@callebtc callebtc deleted the nut-07-use-Y branch March 12, 2024 14:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant