Fix accessibility overlay drawing in root view instead of window manager #1694
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
geoff-powell
requested review from
nak5ive,
gamepro65,
jrodbx and
colinmarsch
geoff-powell
force-pushed
the
gpowell/fix-accessbility-overlay
branch
from
eb066f7 to
b84b39b
Compare
jrodbx
approved these changes
Nov 15, 2024
geoff-powell
force-pushed
the
gpowell/fix-accessbility-overlay
branch
from
b84b39b to
7cd46e2
Compare
geoff-powell
commented
Nov 15, 2024
colinmarsch
approved these changes
Nov 15, 2024
ya, the pixel diff is most likely due to the window manager change. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When debugging #1693 issue I noticed the WindowManagerImpl view can have different sizes based on the window rendered. This caused issues with
AccessibilityRenderExtensionwhere overlay foreground drawable wasn't rendering in the correct place.The fix is to render the content overtop the
ComposeViewAdapterwhich is the root view that gets rendered by paparazzi instead.