Update Backfill Show to use full width tables #411
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
adrw
changed the title
moshegood
reviewed
Jan 23, 2025
| @@ -54,6 +55,10 @@ class BackfillShowAction @Inject constructor( | |||
| val label = | |||
| if (backfill.variant == "default") backfill.service_name else "${backfill.service_name} (${backfill.variant})" | |||
|
|
|||
| val configurationRows = backfill.toConfigurationRows(id) | |||
There was a problem hiding this comment.
What if there is an odd number?
mpawliszyn
reviewed
Jan 24, 2025
mpawliszyn
reviewed
Jan 24, 2025
|
Custom parameter information wasn't there yet, will add in this PR and test for the odd vs even column split. |
adrw
force-pushed
the
2024-01-23.backfillshow
branch
from
93a580e to
fd092e0
Compare
adrw
force-pushed
the
2024-01-23.backfillshow
branch
from
fd092e0 to
a2756ac
Compare
adrw
force-pushed
the
2024-01-23.backfillshow
branch
from
52349be to
2c4171d
Compare
moshegood
approved these changes
Jan 27, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Update Backfill Show to use full width tables
Add custom parameters and handling of odd number of rows