Do not chunk runestone data pushes (ordinals#4036)

casey · Nov 3, 2024 · 12fdfdf · 12fdfdf
1 parent bef31b7
commit 12fdfdf
Show file tree

Hide file tree

Showing 2 changed files with 4 additions and 4 deletions.
diff --git a/crates/ordinals/src/lib.rs b/crates/ordinals/src/lib.rs
@@ -4,7 +4,7 @@
 use {
   bitcoin::{
     consensus::{Decodable, Encodable},
-    constants::{DIFFCHANGE_INTERVAL, MAX_SCRIPT_ELEMENT_SIZE, SUBSIDY_HALVING_INTERVAL},
+    constants::{DIFFCHANGE_INTERVAL, SUBSIDY_HALVING_INTERVAL},
     opcodes,
     script::{self, Instruction},
     Network, OutPoint, ScriptBuf, Transaction,

diff --git a/crates/ordinals/src/runestone.rs b/crates/ordinals/src/runestone.rs
@@ -186,7 +186,7 @@ impl Runestone {
       .push_opcode(opcodes::all::OP_RETURN)
       .push_opcode(Runestone::MAGIC_NUMBER);
 
-    for chunk in payload.chunks(MAX_SCRIPT_ELEMENT_SIZE) {
+    for chunk in payload.chunks(u32::MAX.try_into().unwrap()) {
       let push: &script::PushBytes = chunk.try_into().unwrap();
       builder = builder.push_slice(push);
     }
@@ -1794,7 +1794,7 @@ mod tests {
   }
 
   #[test]
-  fn runestone_payload_is_chunked() {
+  fn runestone_payloads_are_not_chunked() {
     let script = Runestone {
       edicts: vec![
         Edict {
@@ -1823,7 +1823,7 @@ mod tests {
     }
     .encipher();
 
-    assert_eq!(script.instructions().count(), 4);
+    assert_eq!(script.instructions().count(), 3);
   }
 
   #[test]