Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Plug together Arcade and Profile and enable Pin and Share features #1260

Merged
merged 26 commits into from
Jan 16, 2025
Merged

Plug together Arcade and Profile and enable Pin and Share features #1260

merged 26 commits into from
Jan 16, 2025

Conversation

bal7hazar
Copy link
Contributor

No description provided.

@vercel Vercel
Copy link

vercel bot commented Jan 8, 2025 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated (UTC)
ui-next ✅ Ready (Inspect) Visit Preview Jan 16, 2025 7:16pm

@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Jan 8, 2025

🎨 Visual Regression Test Results

❌ Visual differences detected

📦 keychain

⚠️ Visual Differences Detected

The following components have visual differences that need review:

components-connect-createsession--default-chromium

components-connect-createsession--default-chromium

⚠️ Action Required: Please review the visual differences and:

  1. Update the snapshots locally if the changes are intended (scripts/update-storybook-snapshot.sh)
  2. Fix the components if the changes are unintended

@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Jan 9, 2025

🎨 Visual Regression Test Results

✅ No visual changes detected

@github-actions GitHub Actions
Copy link
Contributor

🎨 Visual Regression Test Results

❌ Visual differences detected

📦 keychain

⚠️ Visual Differences Detected

The following components have visual differences that need review:

components-connect-createsession--default-chromium

components-connect-createsession--default-chromium

⚠️ Action Required: Please review the visual differences and:

  1. Update the snapshots locally if the changes are intended (scripts/update-storybook-snapshot.sh)
  2. Fix the components if the changes are unintended

1 similar comment
@github-actions GitHub Actions
Copy link
Contributor

🎨 Visual Regression Test Results

❌ Visual differences detected

📦 keychain

⚠️ Visual Differences Detected

The following components have visual differences that need review:

components-connect-createsession--default-chromium

components-connect-createsession--default-chromium

⚠️ Action Required: Please review the visual differences and:

  1. Update the snapshots locally if the changes are intended (scripts/update-storybook-snapshot.sh)
  2. Fix the components if the changes are unintended

@github-actions GitHub Actions
Copy link
Contributor

🎨 Visual Regression Test Results

❌ Visual differences detected

📦 keychain

⚠️ Visual Differences Detected

The following components have visual differences that need review:

components-connect-createsession--default-chromium

components-connect-createsession--default-chromium

⚠️ Action Required: Please review the visual differences and:

  1. Update the snapshots locally if the changes are intended (scripts/update-storybook-snapshot.sh)
  2. Fix the components if the changes are unintended

@github-actions GitHub Actions
Copy link
Contributor

🎨 Visual Regression Test Results

❌ Visual differences detected

📦 keychain

⚠️ Visual Differences Detected

The following components have visual differences that need review:

components-connect-createsession--default-chromium

components-connect-createsession--default-chromium

⚠️ Action Required: Please review the visual differences and:

  1. Update the snapshots locally if the changes are intended (scripts/update-storybook-snapshot.sh)
  2. Fix the components if the changes are unintended

1 similar comment
@github-actions GitHub Actions
Copy link
Contributor

🎨 Visual Regression Test Results

❌ Visual differences detected

📦 keychain

⚠️ Visual Differences Detected

The following components have visual differences that need review:

components-connect-createsession--default-chromium

components-connect-createsession--default-chromium

⚠️ Action Required: Please review the visual differences and:

  1. Update the snapshots locally if the changes are intended (scripts/update-storybook-snapshot.sh)
  2. Fix the components if the changes are unintended

@github-actions GitHub Actions
Copy link
Contributor

🎨 Visual Regression Test Results

❌ Visual differences detected

📦 keychain

⚠️ Visual Differences Detected

The following components have visual differences that need review:

components-connect-createsession--default-chromium

components-connect-createsession--default-chromium

⚠️ Action Required: Please review the visual differences and:

  1. Update the snapshots locally if the changes are intended (scripts/update-storybook-snapshot.sh)
  2. Fix the components if the changes are unintended

@github-actions GitHub Actions
Copy link
Contributor

🎨 Visual Regression Test Results

❌ Visual differences detected

📦 keychain

⚠️ Visual Differences Detected

The following components have visual differences that need review:

components-connect-createsession--default-chromium

components-connect-createsession--default-chromium

⚠️ Action Required: Please review the visual differences and:

  1. Update the snapshots locally if the changes are intended (scripts/update-storybook-snapshot.sh)
  2. Fix the components if the changes are unintended

@github-actions GitHub Actions
Copy link
Contributor

🎨 Visual Regression Test Results

❌ Visual differences detected

📦 keychain

⚠️ Visual Differences Detected

The following components have visual differences that need review:

components-connect-createsession--default-chromium

components-connect-createsession--default-chromium

⚠️ Action Required: Please review the visual differences and:

  1. Update the snapshots locally if the changes are intended (scripts/update-storybook-snapshot.sh)
  2. Fix the components if the changes are unintended

@bal7hazar bal7hazar marked this pull request as ready for review January 14, 2025 11:13
@github-actions GitHub Actions
Copy link
Contributor

🎨 Visual Regression Test Results

❌ Visual differences detected

📦 keychain

⚠️ Visual Differences Detected

The following components have visual differences that need review:

components-connect-createsession--default-chromium

components-connect-createsession--default-chromium

⚠️ Action Required: Please review the visual differences and:

  1. Update the snapshots locally if the changes are intended (scripts/update-storybook-snapshot.sh)
  2. Fix the components if the changes are unintended

@bal7hazar bal7hazar requested a review from tarrencev January 14, 2025 11:20
bal7hazar
bal7hazar commented Jan 14, 2025
View reviewed changes
examples/next/package.json
@@ -3,7 +3,7 @@
"private": true,
"version": "0.5.8",
"scripts": {
"dev": "next dev -p 3002",
"dev": "next dev -p 3002 --experimental-https",
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Turning the example to HTTPS so we can actually test the prod directly and avoid this:
image

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Will it still work with bin/apidev since the stack will mix http/https?

@github-actions GitHub Actions
Copy link
Contributor

🎨 Visual Regression Test Results

✅ No visual changes detected

@github-actions GitHub Actions
Copy link
Contributor

🎨 Visual Regression Test Results

✅ No visual changes detected

@github-actions GitHub Actions
Copy link
Contributor

🎨 Visual Regression Test Results

✅ No visual changes detected

@github-actions GitHub Actions
Copy link
Contributor

🎨 Visual Regression Test Results

✅ No visual changes detected

@github-actions GitHub Actions
Copy link
Contributor

🎨 Visual Regression Test Results

✅ No visual changes detected

1 similar comment
@github-actions GitHub Actions
Copy link
Contributor

🎨 Visual Regression Test Results

✅ No visual changes detected

@github-actions GitHub Actions
Copy link
Contributor

🎨 Visual Regression Test Results

✅ No visual changes detected

@github-actions GitHub Actions
Copy link
Contributor

🎨 Visual Regression Test Results

✅ No visual changes detected

@bal7hazar bal7hazar merged commit 4acaa77 into main Jan 16, 2025
16 checks passed
@bal7hazar bal7hazar deleted the feat/pin branch January 16, 2025 21:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@broody broody broody approved these changes

@tarrencev tarrencev Awaiting requested review from tarrencev

@JunichiSugiura JunichiSugiura Awaiting requested review from JunichiSugiura

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@bal7hazar @broody