Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Simplify #3

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Simplify #3

wants to merge 1 commit into from

Conversation

treeowl
Copy link

@treeowl treeowl commented Sep 9, 2016

  • Get rid of the weird boxing stuff in favor of Any, the
    officially-approved unsafeCoerce target.
  • Pull the Eithers out of the basic implementation.
  • Expose a dual-continuation version and a simple direct version
    of runSTE.

@treeowl
Copy link
Author

treeowl commented Sep 9, 2016

Everything passes except GHC HEAD. To get it to compile with GHC HEAD I made a private copy of Any—it seems it's no longer exported from GHC.Prim. There seems to be some sort of issue with HSpec for GHC HEAD. Specifically, it can't find some file or other. I very much doubt this is my fault.

@treeowl
Copy link
Author

treeowl commented Sep 9, 2016

By the way, this PR includes both the internals changes and the added API. I can put up whichever of the other two arrangements you want, but not till tomorrow.

@treeowl
Simplify
f14d8ab 
* Get rid of the weird boxing stuff in favor of `Any`, the
  officially-approved `unsafeCoerce` target.

* Pull the `Either`s out of the basic implementation.

* Expose a dual-continuation version and a simple direct version
  of `runSTE`.
@cartazio
Copy link
Owner

I’m actually thinking these days that your ideas here were the right one and I’m gonna circle back on this sometime in the spring. (Nyc being a disaster zone atm and all)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@treeowl @cartazio