Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix config license change, add support for custom license_url #620

Merged
merged 1 commit into from
Nov 22, 2024

Conversation

froggleston
Copy link
Contributor

This PR fixes #619 by:

  • properly using the license key in a lesson config.yaml
  • adding a new config option license_url so that users can supply custom license URLs

There are various config.yaml options:

  • If the license is omitted completely, it will default to CC-BY 4.0, as before, and the footer license href will point to LICENSE.html
  • If a license is supplied, but no license_url is supplied, the footer license href will point to LICENSE.html
  • If a license is supplied and a license_url is supplied, both are used together

@froggleston froggleston self-assigned this Nov 21, 2024
Copy link
Contributor

@ErinBecker ErinBecker left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I've tested both changing the 'license' variable and setting a license_url' variable and both work as described.

@ErinBecker ErinBecker merged commit bf7a758 into main Nov 22, 2024
11 checks passed
@ErinBecker ErinBecker deleted the frog-license-1 branch November 22, 2024 16:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Changes in license in config.yaml does not show up on rendered page.
2 participants